IETF Logo Mail Archive

Re: [quicwg/base-drafts] Consider making long header payload length 16bits (#1577)

Kazuho Oku <notifications@github.com> Thu, 19 July 2018 02:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A8B25130E78 for <quic-issues@ietfa.amsl.com>; Wed, 18 Jul 2018 19:08:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yVWV2gPvDYHA for <quic-issues@ietfa.amsl.com>; Wed, 18 Jul 2018 19:08:19 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3F87B126BED for <quic-issues@ietf.org>; Wed, 18 Jul 2018 19:08:19 -0700 (PDT)
Date: Wed, 18 Jul 2018 19:08:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531966098; bh=OuGme6xbehADojqFQwLICRxBsFFCQCBipptRFuYqKLg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=nRnNZy6pZapg2m0HSLTj9J8s1QRy+NeXxj4QyhhSixlCHG+5xzjQkeCsY+yOj6HX1 MLjL5ikI8GNbjwQMdMBAqE2qyZId7ULz/MzMw7X9Qst1L0EnWEdZQC8EUWBXAw8MEF OSLnjxWSvweuhKNudqQf+HKkz8NOxEGWSKvl5TIg=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3e7e76d8193782c45f656ac70619a06f22d416ec92cf000000011767b49292a169ce146220ed@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1577/406131483@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1577@github.com>
References: <quicwg/base-drafts/issues/1577@github.com>
Subject: Re: [quicwg/base-drafts] Consider making long header payload length 16bits (#1577)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4ff2929616a_30893f89cfaccf541506a8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xYz5a5miW9c48Hbgph2p5tOTZ2Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jul 2018 02:08:22 -0000

@nibanks That argument stands for many other fields. Initial.token_len, Stream.length, ... There are some fields that never becomes greater than 32-bits (i.e. ACK block size).

We can try to have different types for based on each of the requirements. However that causes pain, because we cannot reuse code. That was the pain we had, until we introduced variable integers in #877.

I do not think we need to revert that to reopen tons of issues.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1577#issuecomment-406131483

v2.31.3 | Report a Bug | By Email | System Status