IETF Logo Mail Archive

Re: [quicwg/base-drafts] Integrate QUIC text from DPLPMTUD (#3693)

Gorry Fairhurst <notifications@github.com> Tue, 26 May 2020 07:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86E213A0C60 for <quic-issues@ietfa.amsl.com>; Tue, 26 May 2020 00:21:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qs5qHvrY61PG for <quic-issues@ietfa.amsl.com>; Tue, 26 May 2020 00:21:08 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C2A043A0C34 for <quic-issues@ietf.org>; Tue, 26 May 2020 00:20:08 -0700 (PDT)
Received: from github-lowworker-9d2806a.ash1-iad.github.net (github-lowworker-9d2806a.ash1-iad.github.net [10.56.102.50]) by smtp.github.com (Postfix) with ESMTP id 16E44960C13 for <quic-issues@ietf.org>; Tue, 26 May 2020 00:20:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590477608; bh=nBjVHgvmUAlNE165X9NF9TwP15F7wHFWjqKjb8smD94=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=btukTa86Y1XD7ahywDYrtVZYTfu7eDIMIJOtYyYS6D/RXS/tpBESuI+xIjvuEboZ5 n8ROsN6QeA+mJLBaFC/mGvapuSmiatXZHtpOP/JtyJ8QBswYpdEOGxRbnl1aYV8GO1 zhgflr63uhLRp+Nr+T5iFSCrkui1cz2L4MWSeZAw=
Date: Tue, 26 May 2020 00:20:08 -0700
From: Gorry Fairhurst <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2JX3MSC6AH74VGD2543CSCREVBNHHCKNQYNU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3693/review/418030177@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3693@github.com>
References: <quicwg/base-drafts/pull/3693@github.com>
Subject: Re: [quicwg/base-drafts] Integrate QUIC text from DPLPMTUD (#3693)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eccc3287931_66c3fededecd964513388"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gorryfair
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xZN2iT9Uzjo16OPD_f8C5f6ACO8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2020 07:21:15 -0000

@gorryfair commented on this pull request.



> +These frames might not be retransmitted if a probe packet containing
+them is lost.  The frames consume congestion window,
+which could delay the transmission of subsequent application data.

The initial sentence was already there - I thought it added nothing, so happy to see that removed. 
The fix to the second sentence is broken, but I think this might be /could delay subsequent transmission by the application/?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3693#discussion_r430204334

v2.23.0 | Report a Bug | By Email