Re: [quicwg/base-drafts] RETIRE_KEYS proposal (#2492)

Martin Thomson <notifications@github.com> Fri, 01 March 2019 03:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B2E213114D for <quic-issues@ietfa.amsl.com>; Thu, 28 Feb 2019 19:37:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kzDimmr1t9Mp for <quic-issues@ietfa.amsl.com>; Thu, 28 Feb 2019 19:37:54 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E4A56131166 for <quic-issues@ietf.org>; Thu, 28 Feb 2019 19:37:53 -0800 (PST)
Date: Thu, 28 Feb 2019 19:37:52 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1551411472; bh=sxEAyXWDTf7/ZDNNQFbLkQiw/ADOlF3GAEAOe6B1XaQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=u1UIktnxh2/Gn6JCn4SkA0Qs0FEPnS57I6aJqut7K3XxIWa4e5BSEe3e3aW7htIe1 UqsORjGuadQzm/fIdbgjZPo/jVYA89he3trm46AdX/Fx9GwwcQi5EY9mWJSnbqqCIi fvQ4u7vrW6/TAF/hNXq3bNclSGP7UC31/a+w3+OY=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab967f8745ba7c797653ab1b276a6e0b39450bf1ec92cf0000000118906b1092a169ce18c9ea95@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2492/review/209416350@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2492@github.com>
References: <quicwg/base-drafts/pull/2492@github.com>
Subject: Re: [quicwg/base-drafts] RETIRE_KEYS proposal (#2492)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c78a910ca896_6cbf3f8c710d45c06175d3"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/x_D85duCuxUcMnIwK1gwjZvfmNM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2019 03:37:59 -0000

martinthomson commented on this pull request.



>  Though an endpoint might retain older keys, new data MUST be sent at the highest
 currently-available encryption level.  Only ACK frames and retransmissions of
 data in CRYPTO frames are sent at a previous encryption level.  These packets
 MAY also include PADDING frames.
 
-Once this timer expires, an endpoint MUST NOT either accept or generate new
-packets using those packet protection keys.  An endpoint can discard packet
-protection keys for that encryption level.
+Endpoints coordinate on when to discard unused keys using the RETIRE_KEYS
+frame. At a high level, each endpoint sends a RETIRE_KEYS frame when they
+are done sending using those keys; when an endpoint has both sent and received
+a RETIRE_KEYS frame for a given encryption level, it discards the corresponding
+keys. More specifically, an endpoint is done sending using a given set of keys

This is probably not what you intended here.  I think you mean to say that all *previous* keys are discarded.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2492#pullrequestreview-209416350