Re: [quicwg/base-drafts] Octets that are sent twice (#1353)

MikkelFJ <notifications@github.com> Mon, 14 May 2018 20:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E6FB128961 for <quic-issues@ietfa.amsl.com>; Mon, 14 May 2018 13:53:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GkRJs7wTa4-W for <quic-issues@ietfa.amsl.com>; Mon, 14 May 2018 13:53:41 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6A66512895E for <quic-issues@ietf.org>; Mon, 14 May 2018 13:53:41 -0700 (PDT)
Date: Mon, 14 May 2018 13:53:40 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1526331220; bh=b71HMfcse2e+WZd62rjsn2zYlVWczGrHRlYPmJycydE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zYMzXWPQgFnyAZJZuz3KWYt7N4WDME+Qlsf6BYr5uux5iIKWAboFeq5vh2gJJI30n QeRfeBicC5Opr1CjtBRu4r98OVl0ZCA5ZWEG8Ryo64siM8g/SBNTufnl71hm78be26 VCcl2FgRw4zfjxsBfP3ZXcTTUsAcT7C9fd76olww=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe856955bf8276491f9d53530b6c0015af3dc2a8992cf000000011711b95492a169ce133b2693@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1353/c388959214@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1353@github.com>
References: <quicwg/base-drafts/pull/1353@github.com>
Subject: Re: [quicwg/base-drafts] Octets that are sent twice (#1353)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5af9f7547475a_19273fafe664cf781621e1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xaOAGuXYeOfidP-8j0rvyeCHfgQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 May 2018 20:53:43 -0000

The wonderful mmap api does not guarantee MAP_PRIVATE view remains private on Linux if someone else writes to the file.

I think the requirement of unchanged data is the only sane approach at protocol level, but it can be viewed as a system requirement not the sole responsibility of the QUIC engine because that could range from very expensive to near impossible. Hence, if some other process with adequate permissions overwrite a mmap'ed file being transmitted, that process just violated the QUIC spec.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1353#issuecomment-388959214