Re: [quicwg/base-drafts] Fix GOAWAY connection errors. (#2707)

Lucas Pardue <notifications@github.com> Thu, 16 May 2019 13:43 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 021811200A4 for <quic-issues@ietfa.amsl.com>; Thu, 16 May 2019 06:43:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.392
X-Spam-Level:
X-Spam-Status: No, score=-1.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3oxwrmLUEY-N for <quic-issues@ietfa.amsl.com>; Thu, 16 May 2019 06:43:32 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 810B2120104 for <quic-issues@ietf.org>; Thu, 16 May 2019 06:43:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=W1+GUBQVgY0eWCwOTBlXsS11EzY=; b=jkpWttqb0b5x3KBG L4+UPgRerA6kf53QDEnCSs0EH75DiVvjnSwAP4ffkJIuWJwPD9yFVn1oSQiToxH1 hW19hkAvzQSw4xE98sXDyEqNISKqqu476FoIG4VziU+D/xzB4JrZSIXZseAk3+5r /CSH3FOSO4pE3/tsUej5JLFKppw=
Received: by filter1233p1las1.sendgrid.net with SMTP id filter1233p1las1-13993-5CDD68F8-88 2019-05-16 13:43:20.907796704 +0000 UTC m=+231222.798650875
Received: from github-lowworker-5909e27.cp1-iad.github.net (unknown [140.82.115.7]) by ismtpd0050p1iad1.sendgrid.net (SG) with ESMTP id Oc9agISrRiG0ir1RIj9lUA for <quic-issues@ietf.org>; Thu, 16 May 2019 13:43:20.746 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-5909e27.cp1-iad.github.net (Postfix) with ESMTP id A8D743E1244 for <quic-issues@ietf.org>; Thu, 16 May 2019 06:43:20 -0700 (PDT)
Date: Thu, 16 May 2019 13:43:21 +0000
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK537QFH6TG65CJCAS525KNXREVBNHHBVBJJFU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2707/c493072909@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2707@github.com>
References: <quicwg/base-drafts/pull/2707@github.com>
Subject: Re: [quicwg/base-drafts] Fix GOAWAY connection errors. (#2707)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cdd68f8a6c0f_56043fb8422cd960119769d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2K9CSfrkDec2YvY+2m+M6cZ5OIkx6dRadGWi DpYPejSXKHAuZiNGLbRwQ/3TW3JAklYshj9Ew4CEHFjIvzhF+Jss72xhAfpiVYufzs+EmkNa+XNQbU vJcw7KZQDSkfBEOLH9NS/GuUU1NNuDvqrOLNX9lyTUJRnqHyG2eFNSfxM6R0HgJ+VLQS5axxY/Bzx5 A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xbqXte5tLK-lPZvZodpn9_m1OXs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 May 2019 13:43:34 -0000

Just a note. If this is the right answer and the PR lands, then #2662 will need to replace the new instance of HTTP_MALFORMED_FRAME with something, e.g. HTTP_INVALID_GOAWAY or something

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2707#issuecomment-493072909