IETF Logo Mail Archive

Re: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)

Kazuho Oku <notifications@github.com> Thu, 07 February 2019 02:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A491130FB4 for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 18:05:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6LltFYlNRCCt for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 18:05:11 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 74426130FAB for <quic-issues@ietf.org>; Wed, 6 Feb 2019 18:05:11 -0800 (PST)
Date: Wed, 06 Feb 2019 18:05:10 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549505110; bh=NFTe8ByEtaYfPrecSVcRvcM6WCzZ6qAX3UqMnLGicGY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vBK3z1E4skSaRjrgPMI+jByi+MM+rNd+Ku52+62Z5sXwHg9BKqnaxm9N5h32eXduG JxjQvV5Rva/HPhl7kjnw/3x96MFJHtKt2x4TeEUWrviIgD1qQKBM2MRzshIBmoA8r2 t3XoOD8ZrLqf/zORZUq+JCkZKpNFLY2c/ABwh8Fg=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfe2d68cd6ecf844fb64042d85bab5ccdc91cdd8392cf000000011873545692a169ce183c6fbc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2417/review/200894627@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2417@github.com>
References: <quicwg/base-drafts/pull/2417@github.com>
Subject: Re: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5b92565097c_71823faea02d45b81787c4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xdR25pCSQT4KnCtptznon7VwQy8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 02:05:14 -0000

kazuho approved this pull request.

LGTM modulo the point below.

> @@ -819,6 +819,16 @@ kGranularity:
 kInitialRtt:
 : The RTT used before an RTT sample is taken. The RECOMMENDED value is 100ms.
 
+kPacketNumberSpace:
+: An enum to enumerate the three packet number spaces.
+~~~
+  enum kPacketNumberSpace {
+    Initial,
+    Handshake,
+    1-RTT,

I think the name for the PN space that governs 0- and 1-RTT packets is “application data”.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2417#pullrequestreview-200894627

v2.23.0 | Report a Bug | By Email