IETF Logo Mail Archive

Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)

Marten Seemann <notifications@github.com> Sun, 18 March 2018 09:01 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ADD6012DA01 for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 02:01:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.392
X-Spam-Level:
X-Spam-Status: No, score=-0.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OzYAIRG764Ts for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 02:01:33 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5098B12D959 for <quic-issues@ietf.org>; Sun, 18 Mar 2018 02:01:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=/aNwFYmvh5Xj9wYhVy0jTUYCOGw=; b=WiBNYRx05Ct5sbLo FgtoI56xmmSvrzDqpcuQy+yLtLnOA0TA3gUI/YI3+Ss78uHgE2SB0X018/jcoIyZ Me6eLyFhhjfou8cRCLxMpVF9ME0pBxbSgVNadT9OD5cMDIJu5DZ6VeQU+8VUgNPl RAY0lOLUnIQv8U9lOP57M6GzGLc=
Received: by filter0167p1iad2.sendgrid.net with SMTP id filter0167p1iad2-12723-5AAE2AEC-6 2018-03-18 09:01:32.217241066 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0008p1iad1.sendgrid.net (SG) with ESMTP id ckxqcjd3Tg6p6y7d8PAGvg for <quic-issues@ietf.org>; Sun, 18 Mar 2018 09:01:31.964 +0000 (UTC)
Date: Sun, 18 Mar 2018 09:01:32 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab45b3aa1512b039154351ff226adfe0ad628cef5192cf0000000116c5eceb92a169ce123fc47f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1223/review/104790164@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1223@github.com>
References: <quicwg/base-drafts/pull/1223@github.com>
Subject: Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aae2aebcd964_685b3f8beea00f2894242"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3An9yMWaxe3UW3G1b1V9Of/CQ/lqV0n1KwZ6 Imb/eJu2fkIamJ9GgOxu6yLgsPN+1Y5roIQQOvd1Mveuu/5MIKWgAssvMxp0o17xJOzAW613k/Ymp1 JCdXtpMftf4svogeEJKArIjuo/Uea6G4a49Wx//uwRPsrcaeBxRP13+uiVU5ms1wTLafdJP39dyTRC A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xjdKZnEE-E3W9HmeDtmCEGtaK2Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2018 09:01:36 -0000

marten-seemann commented on this pull request.



>        lost_packets.insert(unacked)
+      sent_packets.remove(unacked.packet_number)
+      if (!unacked.is_ack_only):
+        lost_packets.insert(unacked)

Yes. Fixed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1223#discussion_r175281847

v2.27.8 | Report a Bug | By Email | System Status