Re: [quicwg/base-drafts] Add handling of all packets marked as CE (#3455)

mirjak <notifications@github.com> Fri, 14 February 2020 10:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92888120804 for <quic-issues@ietfa.amsl.com>; Fri, 14 Feb 2020 02:45:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f2TcxrpuenKl for <quic-issues@ietfa.amsl.com>; Fri, 14 Feb 2020 02:45:54 -0800 (PST)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D45D120803 for <quic-issues@ietf.org>; Fri, 14 Feb 2020 02:45:54 -0800 (PST)
Date: Fri, 14 Feb 2020 02:45:53 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581677153; bh=1U2OWNJ3zTbIiDzO/D3TCgFwBSffKCVKiRbH3NQPULk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1Rrd3vzhlvumaEkdRotdO+EyT48onZ/fUKVojPXmzbDlmt7c1dMWQo+kp70KOI7qC rl1anIduXc1XG1iO2SA3ak+RNZhTGCTPkSWp9G/SfS6X1KtEf7+2WIe8kLOKrDOdju o102IJknhtK8mJxkF7Gdj6+QYCtaD7aUmkIcnQb4=
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4ECVCOZG7GXJHX2M54KOWODEVBNHHCDKLF64@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3455/review/358856132@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3455@github.com>
References: <quicwg/base-drafts/pull/3455@github.com>
Subject: Re: [quicwg/base-drafts] Add handling of all packets marked as CE (#3455)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e467a618c200_42953ff8edecd9681260a9"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xk_y2kcNQUGxSKM7TshCRe6miD8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Feb 2020 10:45:57 -0000

mirjak commented on this pull request.



> @@ -3517,6 +3517,13 @@ use the following steps on receiving an ACK frame to validate ECN.
   corresponding ECT codepoint that are newly acknowledged in this ACK frame.
   This step detects any erroneous network remarking from ECT(0) to ECT(1) (or
   vice versa).
+  
+Another special case is when all packets are indicatd as CE marked,
+independtly of the initial codepode used, including Not-ECT. In this case
+it could be a network element overwriting the ECN field of all packets and

I theory this could also be a valid congestion signal. Even if packets were marked Not-ECT there could one element that overwrite it to ECT and another later on that is actually congested and marks validly all packets as CE (I know it's rathe unlikely, just saying...). I found it kind of important to say that this is problematic as it could also conceal valid signals. How about:

"If this is caused by a network element erroneously overwriting the ECN code point field, it will also conceals actual congestion information. Therefore, if a peer indicates that all received packets are ECN-CE marked, endpoints MAY treat this as an ECN validation failure and ignore any ECN-CE counts in acknowledgments."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3455#discussion_r379364866