Re: [quicwg/base-drafts] STOP_SENDING is permitted for Ready streams (#2354)

ianswett <notifications@github.com> Mon, 21 January 2019 19:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3EF7E12D7EA for <quic-issues@ietfa.amsl.com>; Mon, 21 Jan 2019 11:44:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.935
X-Spam-Level:
X-Spam-Status: No, score=-10.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JU2zz3Sk1mr5 for <quic-issues@ietfa.amsl.com>; Mon, 21 Jan 2019 11:44:34 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C66EB12D4EB for <quic-issues@ietf.org>; Mon, 21 Jan 2019 11:44:33 -0800 (PST)
Date: Mon, 21 Jan 2019 11:44:32 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548099872; bh=ENbzLypt7HO11cf0tlAOZXhVD0uvtuqcqFFvTW2a+eY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MakXsLf0RHgi+y341wTwqRD1rofcbrPtdh11SecPtYIBSCShs4APQzWzoGK+kVBpV n62LETjv4KBYUsYqjh/PHfsGma87UGPSAM+2ohSKHUdyuyJuRvRPKzfFcQgq3IA9YZ 1D7P9nyOH4RdLzZvaJmzWsP1E/flGjiiElrb2iSU=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab33949a152081692a92c11a2dc81c2b03eb531eb492cf00000001185de32092a169ce17e982c0@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2354/c456181312@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2354@github.com>
References: <quicwg/base-drafts/pull/2354@github.com>
Subject: Re: [quicwg/base-drafts] STOP_SENDING is permitted for Ready streams (#2354)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c462120e1130_7a803fb831cd45b4382964"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xnVNfZ2EN-uwGVrDhRu4Z3VZrI0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jan 2019 19:44:36 -0000

To clarify, I +1'd your suggestion.

More clearly: "Looks good, but I would like you to accept Dimitri's suggestion before submitting this PR."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2354#issuecomment-456181312