Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)

[Jana Iyengar <[e-mail]>]

janaiyengar requested changes on this pull request.



> @@ -580,14 +580,17 @@ data at Handshake encryption MUST be retransmitted before any ApplicationData
 data.  If no data can be sent, then the PTO alarm MUST NOT be armed until
 data has been received from the client.
 
-Because the server could be blocked until more packets are received, the client
-MUST ensure that the retransmission timer is set if the client does not yet
-have 1-RTT keys.  If the probe timer expires before the client has 1-RTT keys,
-it is possible that the client may not have any crypto data to retransmit.
-However, the client MUST send a new packet to allow the server to continue
-sending data.  At this stage in the connection, when few to none RTT samples
-have been generated, it is possible that the probe timer expiration is due to
-an incorrect RTT estimate at the client. To allow the client to improve its RTT
+Since the server could be blocked until more packets are received from the
+client, it is the client's responsibility to send packets to unblock the server
+until it is certain that the server has finished its address validation
+(see Section 8 of {{QUIC-TRANSPORT}}).  That is, the client MUST set the
+probe timer if one of the following conditions is true: the client
+does not yet have 1-RTT keys, or the client has not received an acknowledgement

```suggestion
does not yet have handshake confirmation, or the client has not received an acknowledgement
```

> @@ -1190,9 +1193,13 @@ SetLossDetectionTimer():
     return
 
   // Don't arm timer if there are no ack-eliciting packets
-  // in flight and the handshake is complete.
-  if (endpoint is client with 1-RTT keys &&
-      no ack-eliciting packets in flight):
+  // in flight and the endpoint is a server. Arm the
+  // timer until the client has received a Handshake ACK
+  // or has completed the handshake.
+  if (no ack-eliciting packets in flight &&
+      (endpoint is server ||
+       has 1-RTT keys ||
+       has received Handshake ACK)):

Chatting about this at the editors meeting, @martinthomson pointed out that this isn't quite right. Here's my reformulation that I believe is the right condition:
"endpoint is server || until the handshake is confirmed || has received Handshake ACK"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2907#pullrequestreview-280506163