Re: [quicwg/base-drafts] Timeout handshake section in recovery draft (#3466)

ianswett <notifications@github.com> Wed, 11 March 2020 05:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C14EF3A11ED for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 22:17:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.696
X-Spam-Level:
X-Spam-Status: No, score=-1.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fbwKfuPxKHss for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 22:17:03 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE3263A11E4 for <quic-issues@ietf.org>; Tue, 10 Mar 2020 22:17:03 -0700 (PDT)
Date: Tue, 10 Mar 2020 22:17:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583903822; bh=Wsx67NqS3QVhnye1tIEdebzY//7wJedbX0BeaaxXQxY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ygj3r3GXmF1yJmbz/KlF19bKzIzgAzMqmSnuTeHLY/TIzxKXpjnjJe5etWqQlxfD0 r+DeZk9Psm4ilm6Rbw0E1p09//UW2KxMpv5OFDRfynPs5o04IPz04LTdB4T2fNdDbn Eizv/BjiH0IO3RO2DUnTalPIk4dwYotO8gOqdPeQ=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK74X2PV3TV557NS5ZN4ORKU5EVBNHHCDQZB7Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3466/review/372480591@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3466@github.com>
References: <quicwg/base-drafts/pull/3466@github.com>
Subject: Re: [quicwg/base-drafts] Timeout handshake section in recovery draft (#3466)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e68744e996ae_33943fafb64cd95c113352"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xvAeYBzhk5-X_yWPDS5zvlANwhw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2020 05:17:08 -0000

ianswett commented on this pull request.



> @@ -532,7 +532,8 @@ otherwise it MUST send an Initial packet in a UDP datagram of at least 1200
 bytes.
 
 Initial packets and Handshake packets could be never acknowledged, but they are
-removed from bytes in flight when the Initial and Handshake keys are discarded.
+removed from bytes in flight when the Initial and Handshake keys are discarded,
+as further described below in section {{discarding-packets}}.

```suggestion
as further described below in Section {{discarding-packets}}.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3466#pullrequestreview-372480591