[quicwg/base-drafts] Gorrys invariant nits (#3731)

Gorry Fairhurst <notifications@github.com> Fri, 05 June 2020 07:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id 6D2F53A1258 for <quic-issues@ietfa.amsl.com>; Fri, 5 Jun 2020 00:15:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id Yhhn6UFuZij7 for <quic-issues@ietfa.amsl.com>; Fri, 5 Jun 2020 00:15:20 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D519B3A0C83 for <quic-issues@ietf.org>; Fri, 5 Jun 2020 00:15:19 -0700 (PDT)
Received: from github-lowworker-cde56e0.va3-iad.github.net (github-lowworker-cde56e0.va3-iad.github.net []) by smtp.github.com (Postfix) with ESMTP id 1400C5203A9 for <quic-issues@ietf.org>; Fri, 5 Jun 2020 00:15:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1591341319; bh=D1VbP/bzHwkUQhUQay2ckEocVnSvn1oUSuDbtEnqNps=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=JVk54pysnUSTQgpbkXUjTRnGn8S4us9p+Jw+oFnzLlBls+Yc6JW4CV51pLHrm6+6G sKJuu8/glBtvvNXrfxcOiie7LWb+Tt/6xo9UWrEJd0MQjp+tDXFrr6xvqSaz1lubzm 6pOyNDXlEqGueUzs6ucq8lGIslTzf/suHSoiV79Y=
Date: Fri, 05 Jun 2020 00:15:19 -0700
From: Gorry Fairhurst <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6SJ2PAL33ASXILEXF44XJANEVBNHHCLIPI4Y@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3731@github.com>
Subject: [quicwg/base-drafts] Gorrys invariant nits (#3731)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ed9f1074756_f5e3f98ad6cd95c48907a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gorryfair
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/y6RCxQvbI3-OVoHwMTE31zCjcXQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jun 2020 07:15:21 -0000

Thanks Gorry, these are all quite helpful.

1) I understand the acronyms DCID and SCID, but these aren't really 
expanded on first use in sect 5.1. 

2) There's mention of "the high bit", but there doesn't seem to be any 
statement of bit order saying. Is it worth declaring network byte/bit 
order earlier in section 4? This also clarifies the placement of fields within a byte, which was basically assumed knowledge otherwise.

3) Personally, I don't think: "The length of the Destination Connection 
 ID is not specified" is a great choice of words. Surely, this needs to 
be specified somewhere for a protocol instance to use it?
This reads better as something like: The length of the Destination Connection ID is not encoded in packets with a short header and is not constrained by this specification.
4) The brackets here seem to point to connection IDs in general, not the  DCID "(see Section 5.3)". Is it worth writing that as "Connection IDs   are described in Section 5", rather than use brackets? The same is true for versions.

5) In section 5.3: "the wrong endpoint" is taken as the wrong transport 
endpoint, but some of our IP and subIP colleagues would use the term 
endpoint for other uses, so one insertion of "transport" would perhaps help?

6) In the appendix A, this: "QUIC forbids acknowledgments of packets" - 
still has me wondering what is actually intended to be understood, 
because the list of bullets is not guarenteed ... :

/The last packet before a long period of quiescence might be assumed 
to contain an acknowledgment (it should be assumed that QUIC could allow acknowledgments of packets that only contain ACK frames)/

I'm not sure what to say here I think the combination of not... forbids threw me off the meaning.

Changes proposed in  #3730

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: