Re: [quicwg/base-drafts] split fast retransmit modes (#1226)

Subodh Iyengar <notifications@github.com> Sun, 18 March 2018 13:49 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 991B612D969 for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 06:49:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.606
X-Spam-Level:
X-Spam-Status: No, score=-0.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WKQVRI_XKtcU for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 06:49:06 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ABFDE12D889 for <quic-issues@ietf.org>; Sun, 18 Mar 2018 06:49:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=SgR1swY88Jnx0cVdjyXkJzof5hs=; b=vS45uFFnexAwx8l3 9JkVg+LHlvSZEj2myl1t1nqZ6gDW0okkhUq3zMonu6o7UH0QSjEF1AKVWnb1HQFx TJcyHXH9i+M2nXNCjGWhsSJS8eVe1WtqNYS0vNJiJs2Wo2vW4tFKj/Y4WIaDbL+P kbRepxOQVPE6XA9D0M5dcBH1c48=
Received: by filter0502p1iad2.sendgrid.net with SMTP id filter0502p1iad2-25761-5AAE6E51-13 2018-03-18 13:49:05.428249379 +0000 UTC
Received: from smtp.github.com (out-3.smtp.github.com [192.30.252.194]) by ismtpd0019p1iad2.sendgrid.net (SG) with ESMTP id qWScwBeHTwmZH_DhrCpI4w for <quic-issues@ietf.org>; Sun, 18 Mar 2018 13:49:05.329 +0000 (UTC)
Date: Sun, 18 Mar 2018 13:49:05 +0000
From: Subodh Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0f260a05624243162dbe694ba3c5fdbb9613c92892cf0000000116c6305192a169ce1240b5ea@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1226/review/104797922@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1226@github.com>
References: <quicwg/base-drafts/pull/1226@github.com>
Subject: Re: [quicwg/base-drafts] split fast retransmit modes (#1226)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aae6e515a1e9_51622ae533d64ec4814842"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: siyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0IG+eNGHITlOHIOck0mqWuaUZmTTcL8KY64b wNfkJRWayp+kPZimdy8ksTzGFNOBHrzmdIBduOgJb72vO0oQq7YbUzHdBSvTMKVg0i2CA4U4I5/Te6 3FL7aUTx+GmNZmYIXxM9073KGrK2gCHA788d3a9SWr6MQKEPZjSYnP74HQW7BVa9p+HCC1yMbTkgdQ w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/y8I63UbQUeVP9AzVJzCbbH8k2Do>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2018 13:49:11 -0000

siyengar commented on this pull request.



> @@ -725,9 +725,9 @@ sent, and then the RTO timer is set.
 
 #### Early Retransmit Alarm
 
-Early retransmit {{?RFC5827}} is implemented with a 1/4 RTT timer. It is
-part of QUIC's time based loss detection, but is always enabled, even when
-only packet reordering loss detection is enabled.
+Early retransmit {{?RFC5827}} is only used when using Fast Retransmit in packet
+number mode. It is implemented with a 1/4 RTT timer. It is part of QUIC's time

this seems a bit confusing, i think we could say something like

``We expect to receive feedback about the sent packet within 1 RTT of the time_since_sent. Early retransmit is implemented by setting a (1 + 1/4) RTT timer since the time the packet is sent. ```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1226#pullrequestreview-104797922