Re: [quicwg/base-drafts] Immediately close with INVALID_TOKEN (#3107)
Jana Iyengar <notifications@github.com> Tue, 05 November 2019 01:29 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 057A2120033 for <quic-issues@ietfa.amsl.com>; Mon, 4 Nov 2019 17:29:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 38nIVAmvcjbz for <quic-issues@ietfa.amsl.com>; Mon, 4 Nov 2019 17:29:18 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 18C5012000F for <quic-issues@ietf.org>; Mon, 4 Nov 2019 17:29:18 -0800 (PST)
Date: Mon, 04 Nov 2019 17:29:17 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572917357; bh=bO3TjsnE4jnb49x1WbkRG3KCeqS2WUnBUnTr6D2CJSA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Isr+VVlygrKYGk9POlOkyOz7UE80/nSYC8/zKXyWK4WCQiuo9R23R7/SL/TTSLw7/ SoAvlESaK2kN/z5ZoFbkG4/bhmV62mww6/D2F3D0TzMcj8WqJ1ixg0yCf5pQ7KMOWV uE9mWbOnlLOQWaZnjB3ezucELv3luuK1at+kLWFY=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYKOOEB6XFYXLOLYAV3ZYBO3EVBNHHB4ST4NM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3107/review/311459110@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3107@github.com>
References: <quicwg/base-drafts/pull/3107@github.com>
Subject: Re: [quicwg/base-drafts] Immediately close with INVALID_TOKEN (#3107)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc0d06d236e7_31c83fc79aecd960131617"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yFHfFQfpuGfmcS2Drz-nFszrKfI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Nov 2019 01:29:20 -0000
janaiyengar commented on this pull request. > @@ -1641,12 +1641,14 @@ of connection establishment. By giving the client a different connection ID to use, a server can cause the connection to be routed to a server instance with more resources available for new connections. -If a server receives a client Initial with an invalid Retry token, -it knows the client will not accept another Retry token. It can either -proceed with the handshake without verifying the token or immediately close -({{immediate-close}}) the connection with an connection error of -INVALID_TOKEN to cause the handshake to fail quickly instead of waiting -for the client to timeout. +If a server receives a client Initial that can be unprotected but contains an +invalid Retry token, it knows the client will not accept another Retry token. +The server can drop such a packet and allow the client to time out to detect +handshake failure, but that is a significant latency penalty to the client. I definitely like this text better. That said, I'm not sure that we should recommend sending a connection close. Esp. when under DoS, we do not want servers doing more work than necessary. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3107#discussion_r342348480
- [quicwg/base-drafts] Immediately close with INVAL… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… Nick Banks
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… Nick Banks
- Re: [quicwg/base-drafts] Immediately close with I… Kazuho Oku
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… Kazuho Oku
- Re: [quicwg/base-drafts] Immediately close with I… Marten Seemann
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… Nick Banks
- Re: [quicwg/base-drafts] Immediately close with I… Mike Bishop
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… Jana Iyengar
- Re: [quicwg/base-drafts] Immediately close with I… Kazuho Oku
- Re: [quicwg/base-drafts] Immediately close with I… MikkelFJ
- Re: [quicwg/base-drafts] Immediately close with I… Kazuho Oku
- Re: [quicwg/base-drafts] Immediately close with I… MikkelFJ
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… Jana Iyengar
- Re: [quicwg/base-drafts] Immediately close with I… Kazuho Oku
- Re: [quicwg/base-drafts] Immediately close with I… Jana Iyengar
- Re: [quicwg/base-drafts] Immediately close with I… Kazuho Oku
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… Jana Iyengar
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… Jana Iyengar
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… ianswett
- Re: [quicwg/base-drafts] Immediately close with I… Kazuho Oku
- Re: [quicwg/base-drafts] Immediately close with I… Marten Seemann
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson
- Re: [quicwg/base-drafts] Immediately close with I… Martin Thomson