Re: [quicwg/base-drafts] Resolve conflicting advice on how to handle Retire Prior To (#3204)

Martin Thomson <notifications@github.com> Mon, 11 November 2019 00:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3C2911200E5 for <quic-issues@ietfa.amsl.com>; Sun, 10 Nov 2019 16:52:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8U7MXmKywp1I for <quic-issues@ietfa.amsl.com>; Sun, 10 Nov 2019 16:52:00 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E33312001A for <quic-issues@ietf.org>; Sun, 10 Nov 2019 16:52:00 -0800 (PST)
Received: from github-lowworker-275fa97.va3-iad.github.net (github-lowworker-275fa97.va3-iad.github.net [10.48.17.64]) by smtp.github.com (Postfix) with ESMTP id 95DE0C60A00 for <quic-issues@ietf.org>; Sun, 10 Nov 2019 16:51:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573433519; bh=KuntdcAL8RYIeNzbFo14s2qHYDSv9IbU/+IWeVkmBB0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HAOMWeGA6qQe5v1vSvssI3ct0XDqvEJsMkv6ShCVJclUMbVwDZ1iR+sD986eiIDoG /UrqsGEozOBoOhdLEUcjj1fkOv+el9Eyz2w9sQ4oVS96LKTEjj9TWAlYcMTUtHdso0 Z/Bvj3sK4Tayl/Znas7OuCA1gx5m77+4RFY/M7IE=
Date: Sun, 10 Nov 2019 16:51:59 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7QE42S5BPFRWCENEN32XRS7EVBNHHB57AENQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3204/review/314655943@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3204@github.com>
References: <quicwg/base-drafts/pull/3204@github.com>
Subject: Re: [quicwg/base-drafts] Resolve conflicting advice on how to handle Retire Prior To (#3204)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc8b0af871d8_39353fc3acacd96015136f9"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yFJs7evgZ4VAVW9RJrCcYI9nTpQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Nov 2019 00:52:03 -0000

martinthomson approved this pull request.



> @@ -1033,11 +1033,10 @@ longer plans to use that address.
 
 An endpoint can cause its peer to retire connection IDs by sending a
 NEW_CONNECTION_ID frame with an increased Retire Prior To field.  Upon receipt,
-the peer MUST retire the corresponding connection IDs and send corresponding
-RETIRE_CONNECTION_ID frames.  Failing to retire the connection IDs within
-approximately one PTO can cause packets to be delayed, lost, or cause the
-original endpoint to send a stateless reset in response to a connection ID it
-can no longer route correctly.
+the peer MUST retire the corresponding connection IDs via RETIRE_CONNECTION_ID

```suggestion
the peer MUST retire the corresponding connection IDs using RETIRE_CONNECTION_ID
```

> @@ -5392,15 +5391,10 @@ sequence number, or if a sequence number is used for different connection
 IDs, the endpoint MAY treat that receipt as a connection error of type
 PROTOCOL_VIOLATION.
 
-The Retire Prior To field is a request for the peer to retire all connection IDs
-with a sequence number less than the specified value.  This includes the initial
-and preferred_address transport parameter connection IDs.  The peer SHOULD
-retire the corresponding connection IDs and send the corresponding
-RETIRE_CONNECTION_ID frames in a timely manner.
-
-The Retire Prior To field MUST be less than or equal to the Sequence Number
-field.  Receiving a value greater than the Sequence Number MUST be treated as a
-connection error of type FRAME_ENCODING_ERROR.
+The Retire Prior To field (see {{retiring-cids}}) includes the initial and
+preferred_address transport parameter connection IDs and MUST be less than or

Two sentences, I think:

> The Retire Prior To field counts connection IDs established during connection setup and the preferred_address transport parameter (see {{retiring-cids}}).  The Retire Prior To field MUST be less than or equal to the Sequence Number field.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3204#pullrequestreview-314655943