Re: [quicwg/base-drafts] Largest acked in ACK frame MUST NOT decrease (#2205)

Jana Iyengar <notifications@github.com> Wed, 22 May 2019 13:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF174120128 for <quic-issues@ietfa.amsl.com>; Wed, 22 May 2019 06:47:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.606
X-Spam-Level:
X-Spam-Status: No, score=-1.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nwBf_N5bH8Lv for <quic-issues@ietfa.amsl.com>; Wed, 22 May 2019 06:47:56 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E281B120131 for <quic-issues@ietf.org>; Wed, 22 May 2019 06:47:55 -0700 (PDT)
Date: Wed, 22 May 2019 06:47:54 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1558532874; bh=aDqQpGkyzK1okPVSSEYbsGsreaiUP1B+WWqWMW/t2V8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tOwGWhU5PHAw84t0pLoBLs2Vujl569dUYFpY3x3hh3+psFoGY3slhVrucOHkw3XmT NCT8CoIEuQlV3sbAU1gCvo5gpU7M4B6S1zqrKdmB9qxwRO/GOZG44+KMmID5U+P+XA 6aKCMhUvYnLp9os0Po3k5CE0pmpQiimKsOcxQxog=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK65UTNDXJUJIYBPTUN26KCYVEVBNHHBOYXNSM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2205/494810073@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2205@github.com>
References: <quicwg/base-drafts/issues/2205@github.com>
Subject: Re: [quicwg/base-drafts] Largest acked in ACK frame MUST NOT decrease (#2205)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ce5530aad9e3_27633f87068cd9681094096"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yG3-6bglATO0jnHiQHOTHduw3ak>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 May 2019 13:47:58 -0000

I think this is mostly addressed and what's left is OBE. There's text in the draft now that says: "Processing counts out of order can result in verification failure. An endpoint SHOULD NOT perform this verification if the ACK frame is received in a packet with packet number lower than a previously received ACK frame. Verifying based on ACK frames that arrive out of order can result in disabling ECN unnecessarily."

This would be adequate, but there's other text (thanks to #2312) that says old ACKs can be resent. I think we simply add a note about that in the para above, which should be adequate.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2205#issuecomment-494810073