Re: [quicwg/base-drafts] MUST ACK each ack-eliciting packet once (#3092)

Martin Thomson <notifications@github.com> Tue, 22 October 2019 04:27 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F3033120074 for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:27:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.596
X-Spam-Level:
X-Spam-Status: No, score=-1.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JKs00wiba2dT for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:27:13 -0700 (PDT)
Received: from xtrwsrhn.outbound-mail.sendgrid.net (xtrwsrhn.outbound-mail.sendgrid.net [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A6F4E12004F for <quic-issues@ietf.org>; Mon, 21 Oct 2019 21:27:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=eKjL7oauf5TlZEON4Fo0mNV4Dg4=; b=PQxPCTcpGkULXWAc 3NZMzJ3kV95gmOYxj20W9smJIeVmMXjoW0UV41sQ4KbUmh410m1zlw3Tq+lc2Kct pWMkyV3lNFKqo2scVkBnFgdHpF95ZRjB9IDxspxP94gnguxma/X771hV4xQmy11o WcD9DzTD+JUqxf6/2WdUkWSfIoE=
Received: by filter0762p1las1.sendgrid.net with SMTP id filter0762p1las1-26953-5DAE7585-15 2019-10-22 03:20:37.720729107 +0000 UTC m=+362320.577364192
Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) by ismtpd0010p1las1.sendgrid.net (SG) with ESMTP id Etm1cvoyT1KDZvtnWCZQDw for <quic-issues@ietf.org>; Tue, 22 Oct 2019 03:20:37.666 +0000 (UTC)
Date: Tue, 22 Oct 2019 03:20:38 +0000 (UTC)
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZNJ5XVWGA23B6LSAV3XOT77EVBNHHB4ODZTE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3092/review/304948609@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3092@github.com>
References: <quicwg/base-drafts/pull/3092@github.com>
Subject: Re: [quicwg/base-drafts] MUST ACK each ack-eliciting packet once (#3092)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dae757fb8425_61453fc220ecd96c1952e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2bNdNcDYe2NfJuMiGeyYjsGQM/3QIUCQWL1j SLbF8invjKqouRWWbOuPS6Da83Xut6Ns641pU9bSXQ4DPa1kDKLPtpYDOy3s3Ou9V9HZAg5UmJdPa6 HR3NQOciPTsDoyIqQlohKva1Z2u/Tr1a3p6lXSjiWqFcdjP30XaNdSIRzipTBbm/BCXX3tM8XjKjvm g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yKmKowWAP_xuu-TfCaEPa-79G6o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 04:27:15 -0000

martinthomson commented on this pull request.



> @@ -3007,9 +3007,6 @@ guidance offered below seeks to strike this balance.
 
 ### Sending ACK Frames {#sending-acknowledgements}
 
-An ACK frame SHOULD be generated for at least every second ack-eliciting packet.
-This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
-
 An endpoint MUST NOT excessively delay acknowledgements of ack-eliciting

I think that we're still missing the "An endpoint MUST send at least one acknowledgment for every packet it receives and successfully processes."  This paragraph is mostly about max ack delay, which is fine, but it only really says that you can't excessively delay.

Sure, you could say that "never send" == "excessive delay", but you could also say that you can't delay something that never existed in the first place.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3092#pullrequestreview-304948609