Re: [quicwg/base-drafts] First octet changes (#2006)
Kazuho Oku <notifications@github.com> Thu, 15 November 2018 06:04 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F2E7E12D4E9 for <quic-issues@ietfa.amsl.com>; Wed, 14 Nov 2018 22:04:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83u_xaOlZwua for <quic-issues@ietfa.amsl.com>; Wed, 14 Nov 2018 22:04:36 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DDC71124BE5 for <quic-issues@ietf.org>; Wed, 14 Nov 2018 22:04:35 -0800 (PST)
Date: Wed, 14 Nov 2018 22:04:35 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542261875; bh=SD557iBd3Xmr0gPAlKMuXHJdyy8ao6CRqKWyBjk+/D0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ccl0WvuDkeexFPIDLKHNyGMPv4J75V/f6m95R5YvI3+96ZgZxpltvi0xKQfthSw23 nHaFbfiCA5iomKGjUzpcZLwhroXJlbiRkL24rPiienkVVflN+RQVGJmvV07rpL1EUy Ps2T5Xk2XrpyGsEqa1fUpFeMcsPcztoQEDORE6KU=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd6197426b6afa044bc30d1c56ee994a93cc497d092cf000000011804ce7392a169ce16b57ba1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2006/review/175201440@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2006@github.com>
References: <quicwg/base-drafts/pull/2006@github.com>
Subject: Re: [quicwg/base-drafts] First octet changes (#2006)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bed0c7332f3c_42e03fec520d45c011807d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yRn4XfIzVU_MYXqlyY8a74CjNGk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Nov 2018 06:04:38 -0000
kazuho commented on this pull request.
> @@ -771,10 +771,9 @@ used for QUIC packet protection is the AEAD that is negotiated for use with the
TLS connection. For example, if TLS is using the TLS_AES_128_GCM_SHA256, the
AEAD_AES_128_GCM function is used.
-QUIC packets are protected prior to applying packet number protection
-({{pn-encrypt}}). The unprotected packet number is part of the associated data
-(A). When removing packet protection, an endpoint first removes the protection
-from the packet number.
+Packets are protected prior to applying header protection ({{header-protect}}).
I think that you might want to call the AEAD process "payload protection", rather than referring to it like "packets are protected". IMO doing so would better clarify that we have two encryption: one that encrypts the payload and one that encrypts the header.
I understand that such change puts burden on the editors, so just saying.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2006#pullrequestreview-175201440
- Re: [quicwg/base-drafts] First byte changes (#200… Martin Thomson
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- [quicwg/base-drafts] First octet changes (#2006) Martin Thomson
- Re: [quicwg/base-drafts] First octet changes (#20… Marten Seemann
- Re: [quicwg/base-drafts] First octet changes (#20… Marten Seemann
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… Marten Seemann
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… janaiyengar
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- Re: [quicwg/base-drafts] First octet changes (#20… Marten Seemann
- Re: [quicwg/base-drafts] First octet changes (#20… Marten Seemann
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- Re: [quicwg/base-drafts] First octet changes (#20… Marten Seemann
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… ianswett
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- Re: [quicwg/base-drafts] First octet changes (#20… David Schinazi
- Re: [quicwg/base-drafts] First octet changes (#20… David Schinazi
- Re: [quicwg/base-drafts] First octet changes (#20… erickinnear
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- Re: [quicwg/base-drafts] First octet changes (#20… David Schinazi
- Re: [quicwg/base-drafts] First octet changes (#20… David Schinazi
- Re: [quicwg/base-drafts] First octet changes (#20… David Schinazi
- Re: [quicwg/base-drafts] First octet changes (#20… David Schinazi
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- Re: [quicwg/base-drafts] First octet changes (#20… David Schinazi
- Re: [quicwg/base-drafts] First octet changes (#20… David Schinazi
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… Dmitri Tikhonov
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… David Schinazi
- Re: [quicwg/base-drafts] First octet changes (#20… Christian Huitema
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- Re: [quicwg/base-drafts] First octet changes (#20… Martin Thomson
- Re: [quicwg/base-drafts] First octet changes (#20… Dirkjan Ochtman
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… Martin Thomson
- Re: [quicwg/base-drafts] First octet changes (#20… Marten Seemann
- Re: [quicwg/base-drafts] First octet changes (#20… Marten Seemann
- Re: [quicwg/base-drafts] First octet changes (#20… Christian Huitema
- Re: [quicwg/base-drafts] First octet changes (#20… Kazuho Oku
- Re: [quicwg/base-drafts] First octet changes (#20… Martin Thomson
- Re: [quicwg/base-drafts] First octet changes (#20… Martin Thomson
- Re: [quicwg/base-drafts] First octet changes (#20… Martin Thomson
- Re: [quicwg/base-drafts] First octet changes (#20… MikkelFJ
- Re: [quicwg/base-drafts] First octet changes (#20… Martin Thomson
- Re: [quicwg/base-drafts] First byte changes (#200… Kazuho Oku
- Re: [quicwg/base-drafts] First byte changes (#200… Martin Thomson
- Re: [quicwg/base-drafts] First byte changes (#200… Kazuho Oku
- Re: [quicwg/base-drafts] First byte changes (#200… Martin Thomson
- Re: [quicwg/base-drafts] First byte changes (#200… Kazuho Oku
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… ianswett
- Re: [quicwg/base-drafts] First byte changes (#200… Christian Huitema
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… Mike Bishop
- Re: [quicwg/base-drafts] First byte changes (#200… MikkelFJ
- Re: [quicwg/base-drafts] First byte changes (#200… David Schinazi
- Re: [quicwg/base-drafts] First byte changes (#200… David Schinazi
- Re: [quicwg/base-drafts] First byte changes (#200… Dmitri Tikhonov
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… Marten Seemann
- Re: [quicwg/base-drafts] First byte changes (#200… Martin Thomson
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… Kazuho Oku
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… Kazuho Oku
- Re: [quicwg/base-drafts] First byte changes (#200… Alexandre Ferrieux
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… Kazuho Oku
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… Martin Thomson
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… Martin Thomson
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… Martin Thomson
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… janaiyengar
- Re: [quicwg/base-drafts] First byte changes (#200… Kazuho Oku
- Re: [quicwg/base-drafts] First byte changes (#200… MikkelFJ
- Re: [quicwg/base-drafts] First byte changes (#200… janaiyengar
- Re: [quicwg/base-drafts] First byte changes (#200… Igor Lubashev
- Re: [quicwg/base-drafts] First byte changes (#200… Christian Huitema
- Re: [quicwg/base-drafts] First byte changes (#200… Martin Thomson