Date: Mon, 18 Nov 2019 00:04:24 -0800
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK2X4BTYKWK7S4DLUVN336BQREVBNHHB475TUU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3145/review/318150456@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3145@github.com>
References: <quicwg/base-drafts/pull/3145@github.com>
Subject: Re: [quicwg/base-drafts] use a HANDSHAKE_DONE frame to drive the
 handshake to confirmation (#3145)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5dd250887a670_74843fc452ccd96c204041";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yTmxBGePWTxO2YLiIlDUUo4mzXw>


----==_mimepart_5dd250887a670_74843fc452ccd96c204041
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

marten-seemann commented on this pull request.



> @@ -5495,6 +5497,24 @@ Reason Phrase:
   This SHOULD be a UTF-8 encoded string {{!RFC3629}}.
 
 
+## HANDSHAKE_DONE frame {#handshake-done-frame}
+
+The server uses the HANDSHAKE_DONE frame (type=0x1e) to signal confirmation of
+the handshake to the client.  The HANDSHAKE_DONE frame contains no additional
+fields.
+
+This frame can only be sent by the server. Servers MUST NOT send a
+HANDSHAKE_DONE frame before completing the handshake.  A server MUST treat
+receipt of a HANDSHAKE_DONE frame as a connection error of type
+PROTOCOL_VIOLATION.
+
+A client MAY treat receipt of an acknowledgment for a packet it sent with 1-RTT
+keys as receipt of a HANDSHAKE_DONE frame.  This can be implemented by recording

Thanks. I applied your suggestion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3145#discussion_r347240088
----==_mimepart_5dd250887a670_74843fc452ccd96c204041
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@marten-seemann</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3145#discussion_r347240088">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -5495,6 +5497,24 @@ Reason Phrase:
   This SHOULD be a UTF-8 encoded string {{!RFC3629}}.
 
 
+## HANDSHAKE_DONE frame {#handshake-done-frame}
+
+The server uses the HANDSHAKE_DONE frame (type=0x1e) to signal confirmation of
+the handshake to the client.  The HANDSHAKE_DONE frame contains no additional
+fields.
+
+This frame can only be sent by the server. Servers MUST NOT send a
+HANDSHAKE_DONE frame before completing the handshake.  A server MUST treat
+receipt of a HANDSHAKE_DONE frame as a connection error of type
+PROTOCOL_VIOLATION.
+
+A client MAY treat receipt of an acknowledgment for a packet it sent with 1-RTT
+keys as receipt of a HANDSHAKE_DONE frame.  This can be implemented by recording
</pre>
<p>Thanks. I applied your suggestion.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3145?email_source=notifications&amp;email_token=AFTOJK2YJJRGA5L6TVUU7YDQUJEARA5CNFSM4JEOIBD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL3JOOA#discussion_r347240088">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJKYRPDBRNTQI3XA34VTQUJEARANCNFSM4JEOIBDQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKY2WJOK2SCTUELJZ73QUJEARA5CNFSM4JEOIBD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL3JOOA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3145?email_source=notifications\u0026email_token=AFTOJK2YJJRGA5L6TVUU7YDQUJEARA5CNFSM4JEOIBD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL3JOOA#discussion_r347240088",
"url": "https://github.com/quicwg/base-drafts/pull/3145?email_source=notifications\u0026email_token=AFTOJK2YJJRGA5L6TVUU7YDQUJEARA5CNFSM4JEOIBD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCL3JOOA#discussion_r347240088",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5dd250887a670_74843fc452ccd96c204041--