Date: Tue, 18 Jun 2019 17:44:39 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZKFSHGQOPJ2ESDIAN3C237PEVBNHHBVGVFRE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2731/review/251427194@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2731@github.com>
References: <quicwg/base-drafts/pull/2731@github.com>
Subject: Re: [quicwg/base-drafts] Transport editorial suggestions (#2731)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5d0985778ab62_63633fe9580cd95c235417";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yTq0kX0qaK7eH9o7asOx0PZC-YQ>


----==_mimepart_5d0985778ab62_63633fe9580cd95c235417
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.

Thanks, I'm going to remove that paragraph.

> @@ -1336,11 +1335,7 @@ and sets the SCIL field to indicate the length.
 The first flight of 0-RTT packets use the same Destination and Source Connection
 ID values as the client's first Initial.
 
-The Destination Connection ID field in the server's Initial packet contains a
-connection ID that is chosen by the recipient of the packet (i.e., the client);
-the Source Connection ID includes the connection ID that the sender of the
-packet wishes to use (see {{connection-id}}). The server MUST use consistent
-Source Connection IDs during the handshake.
+The server MUST use consistent Source Connection IDs during the handshake.

Weirdly, this text was already there, see lines 1342/1343.

But I agree, this is clearly incorrect or depends upon the definition of consistent, which I don't believe is worth defining.  I'm going to remove this paragraph.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2731#pullrequestreview-251427194
----==_mimepart_5d0985778ab62_63633fe9580cd95c235417
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<p>Thanks, I'm going to remove that paragraph.</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2731#discussion_r295081951">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1336,11 +1335,7 @@ and sets the SCIL field to indicate the length.
 The first flight of 0-RTT packets use the same Destination and Source Connection
 ID values as the client&#39;s first Initial.
 
-The Destination Connection ID field in the server&#39;s Initial packet contains a
-connection ID that is chosen by the recipient of the packet (i.e., the client);
-the Source Connection ID includes the connection ID that the sender of the
-packet wishes to use (see {{connection-id}}). The server MUST use consistent
-Source Connection IDs during the handshake.
+The server MUST use consistent Source Connection IDs during the handshake.
</pre>
<p>Weirdly, this text was already there, see lines 1342/1343.</p>
<p>But I agree, this is clearly incorrect or depends upon the definition of consistent, which I don't believe is worth defining.  I'm going to remove this paragraph.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2731?email_source=notifications&amp;email_token=AFTOJKZV5SIKMNAEYHKJ7Y3P3F6PPA5CNFSM4HOGAGX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB36HS6Q#pullrequestreview-251427194">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK23NO6IIOP7XT67YS3P3F6PPANCNFSM4HOGAGXQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AFTOJK6I7KXATHP2AN6D22TP3F6PPA5CNFSM4HOGAGX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB36HS6Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2731?email_source=notifications\u0026email_token=AFTOJKZV5SIKMNAEYHKJ7Y3P3F6PPA5CNFSM4HOGAGX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB36HS6Q#pullrequestreview-251427194",
"url": "https://github.com/quicwg/base-drafts/pull/2731?email_source=notifications\u0026email_token=AFTOJKZV5SIKMNAEYHKJ7Y3P3F6PPA5CNFSM4HOGAGX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB36HS6Q#pullrequestreview-251427194",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5d0985778ab62_63633fe9580cd95c235417--