[quicwg/base-drafts] Allow PING in Initial/Handshake? (#3034)

Alessandro Ghedini <notifications@github.com> Sun, 15 September 2019 11:06 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id E6ED7120026 for <quic-issues@ietfa.amsl.com>; Sun, 15 Sep 2019 04:06:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id YSC4c2leUXrU for <quic-issues@ietfa.amsl.com>; Sun, 15 Sep 2019 04:06:42 -0700 (PDT)
Received: from out-11.smtp.github.com (out-11.smtp.github.com []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E900312000F for <quic-issues@ietf.org>; Sun, 15 Sep 2019 04:06:41 -0700 (PDT)
Date: Sun, 15 Sep 2019 04:06:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568545601; bh=nKX8cWeYCjiNevCYBEEa/BAiGr8kCgl6Tx92pKF1Pj4=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=RE2zQ+f91TkBp7aYn3LQrE617Q89uo4itLQ0Nqm0iOizZXOd6UWKsDHvtfS9uG70f ICQsRi+w1TpKmlEAQaaF9TV4nO+oaFOMdB4hgNj01jD3Nnphd2phbbSkLEjhansCMG yKwKPXezQemsDb0zPFLSLyFrJo/XbQgXD65sseX8=
From: Alessandro Ghedini <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4PSABWR2OBCH5XMDV3RNN5DEVBNHHB23NCOM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3034@github.com>
Subject: [quicwg/base-drafts] Allow PING in Initial/Handshake? (#3034)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d7e1b4112e26_16763ff189ecd9601172093"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ghedo
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yWS_OsWt8NtAhspEXzTrhxj36yc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Sep 2019 11:06:44 -0000

So, currently PING frames can only be sent in 0/1-RTT as per the TLS mapping draft

AFAICT the issue of allowing PING frames in Initial/Handshake packets was discussed in https://github.com/quicwg/base-drafts/issues/2640 which was in turn fixed by https://github.com/quicwg/base-drafts/pull/2642 by saying to only send PADDING frames in probe packets. But then https://github.com/quicwg/base-drafts/pull/2912 came along which changed the same text by saying that probes need to be ACK-eliciting.

Notably it says:

> To allow the client to improve its RTT estimate, the new packet that it sends MUST be ack-eliciting.  If Handshake keys are available to the client, it MUST send a Handshake packet, and otherwise it MUST send an Initial packet in a UDP datagram of at least 1200 bytes.

In the case where no other frame needs to be sent, but 1-RTT keys are not available, an implementation can send an empty CRYPTO frame to achieve the above as suggested by @tatsuhiro-t, so I proposed an editorial change in https://github.com/quicwg/base-drafts/pull/3033 to expand the suggestion in -recovery to mention that, since I think it's something that would be easy to miss (and indeed, I don't think my implementation is the only one that got this wrong).

However some people seem to prefer allowing PING frames in Initial/Handshake in the first place (which is a design change), so maybe we should discuss this more. That anyone knows, is there any reason why PING frames are not allowed in Initial/Handshake?

(I'll make a PR shortly to help discussion)

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: