Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6F1233A0A6C for ; Tue, 21 Jul 2020 13:53:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -1.697 X-Spam-Level: X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I7SikaUpBLPz for ; Tue, 21 Jul 2020 13:53:42 -0700 (PDT) Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2946F3A0A6A for ; Tue, 21 Jul 2020 13:53:42 -0700 (PDT) Received: from github-lowworker-f144ac1.va3-iad.github.net (github-lowworker-f144ac1.va3-iad.github.net [10.48.16.59]) by smtp.github.com (Postfix) with ESMTP id 799026E0DAF for ; Tue, 21 Jul 2020 13:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595364821; bh=Am3lSMidJAMfI9DD4iDgKgT4wBTIItzLKuQ0srpVwAg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wq+BATdduk+viqbsabEIWexCMflMG7KNFTPVVEK7//xqmgLGzih7s/T00KjXugmJl wd9XSQG9kfiRwtyz5JZVJvvBtvHH8kP8viaaCQoZtGAtY86xI253XyW+idVAJp7mWJ kFkP6JfexTlvz/4RXsmaYTNZBMD6Z5wLC7N0jI4Q= Date: Tue, 21 Jul 2020 13:53:41 -0700 From: Lucas Pardue Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Rework flow of Push ID (#3925) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5f1755d56af63_12803fe07c4cd960183390"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: LPardue X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 20:53:44 -0000 ----==_mimepart_5f1755d56af63_12803fe07c4cd960183390 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @LPardue commented on this pull request. > - -Server push is only enabled on a connection when a client sends a MAX_PUSH_ID -frame; see {{frame-max-push-id}}. A server cannot use server push until it -receives a MAX_PUSH_ID frame. A client sends additional MAX_PUSH_ID frames to -control the number of pushes that a server can promise. A server SHOULD use Push -IDs sequentially, starting at 0. A client MUST treat receipt of a push stream -with a Push ID that is greater than the maximum Push ID as a connection error of -type H3_ID_ERROR. +Each server push is identified by a unique Push ID, which is used to refer to +the push in various contexts throughout the lifetime of the connection. + +The Push ID space begins at zero, and ends at a maximum value set by the +MAX_PUSH_ID frame; see {{frame-max-push-id}}. Server push is only enabled on a +connection when a client sends a MAX_PUSH_ID frame. A client sends additional +MAX_PUSH_ID frames to control the number of pushes that a server can promise. A +server SHOULD use Push IDs sequentially. A client MUST treat receipt of a push Good point about detecting difficulties -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3925#discussion_r458380946 ----==_mimepart_5f1755d56af63_12803fe07c4cd960183390 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@LPardue commented on this pull request.

In draft-ietf-quic-http.md:

> -
-Server push is only enabled on a connection when a client sends a MAX_PUSH_ID
-frame; see {{frame-max-push-id}}. A server cannot use server push until it
-receives a MAX_PUSH_ID frame. A client sends additional MAX_PUSH_ID frames to
-control the number of pushes that a server can promise. A server SHOULD use Push
-IDs sequentially, starting at 0. A client MUST treat receipt of a push stream
-with a Push ID that is greater than the maximum Push ID as a connection error of
-type H3_ID_ERROR.
+Each server push is identified by a unique Push ID, which is used to refer to
+the push in various contexts throughout the lifetime of the connection.
+
+The Push ID space begins at zero, and ends at a maximum value set by the
+MAX_PUSH_ID frame; see {{frame-max-push-id}}.  Server push is only enabled on a
+connection when a client sends a MAX_PUSH_ID frame.  A client sends additional
+MAX_PUSH_ID frames to control the number of pushes that a server can promise.  A
+server SHOULD use Push IDs sequentially.  A client MUST treat receipt of a push

Good point about detecting difficulties

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

----==_mimepart_5f1755d56af63_12803fe07c4cd960183390--