Date: Wed, 19 Jun 2019 18:24:21 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK5XMLFF4CLFK46PAOV3DAJMLEVBNHHBVGVFRE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2731/review/252043148@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2731@github.com>
References: <quicwg/base-drafts/pull/2731@github.com>
Subject: Re: [quicwg/base-drafts] Transport editorial suggestions (#2731)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5d0ae045d006c_73613fb9ad6cd96813567c";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yfXMCRBrCIxmQD-gkivKjY1wO6E>


----==_mimepart_5d0ae045d006c_73613fb9ad6cd96813567c
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson approved this pull request.



> @@ -1323,26 +1322,20 @@ Destination Connection ID field of packets being sent to them.  Upon receiving a
 packet, each endpoint sets the Destination Connection ID it sends to match the
 value of the Source Connection ID that they receive.
 
-When an Initial packet is sent by a client which has not previously received a
-Retry packet from the server, it populates the Destination Connection ID field
-with an unpredictable value.  This MUST be at least 8 bytes in length. Until a
-packet is received from the server, the client MUST use the same value unless it
-abandons the connection attempt and starts a new one. The initial Destination
-Connection ID is used to determine packet protection keys for Initial packets.
+When an Initial packet is sent by a client which has not previously received an

```suggestion
When an Initial packet is sent by a client that has not previously received an
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2731#pullrequestreview-252043148
----==_mimepart_5d0ae045d006c_73613fb9ad6cd96813567c
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@martinthomson</b> approved this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/2731#discussi=
on_r295582399">draft-ietf-quic-transport.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -1323,26 +1322,20 @@ Destination Connec=
tion ID field of packets being sent to them.  Upon receiving a=0D
 packet, each endpoint sets the Destination Connection ID it sends to mat=
ch the=0D
 value of the Source Connection ID that they receive.=0D
 =0D
-When an Initial packet is sent by a client which has not previously rece=
ived a=0D
-Retry packet from the server, it populates the Destination Connection ID=
 field=0D
-with an unpredictable value.  This MUST be at least 8 bytes in length. U=
ntil a=0D
-packet is received from the server, the client MUST use the same value u=
nless it=0D
-abandons the connection attempt and starts a new one. The initial Destin=
ation=0D
-Connection ID is used to determine packet protection keys for Initial pa=
ckets.=0D
+When an Initial packet is sent by a client which has not previously rece=
ived an=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-When an Initial packet is sent by a client wh=
ich has not previously received an=0D
+When an Initial packet is sent by a client that has not previously recei=
ved an=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/2731?email_source=3Dnotifications&amp;email_token=3DA=
FTOJKZBT6LAMIJJXNW5MUDP3LL4LA5CNFSM4HOGAGX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4C57DA#pullrequestreview-252043148=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK3QDJNOVJ6SRUELJHTP3LL4LANCNFSM4HOGAGXQ">mute the th=
read</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJK3Q5NRX=
LG2NDZJ6HRTP3LL4LA5CNFSM4HOGAGX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FE=
ZLWNFSXPKTDN5WW2ZLOORPWSZGOB4C57DA.gif" height=3D"1" width=3D"1" alt=3D""=
 /></p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/2731?email_source=3D=
notifications\u0026email_token=3DAFTOJKZBT6LAMIJJXNW5MUDP3LL4LA5CNFSM4HOG=
AGX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB=
4C57DA#pullrequestreview-252043148",=0D
"url": "https://github.com/quicwg/base-drafts/pull/2731?email_source=3Dno=
tifications\u0026email_token=3DAFTOJKZBT6LAMIJJXNW5MUDP3LL4LA5CNFSM4HOGAG=
X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4C=
57DA#pullrequestreview-252043148",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5d0ae045d006c_73613fb9ad6cd96813567c--