Re: [quicwg/base-drafts] Unidirectional Streams (#643)
Martin Thomson <notifications@github.com> Tue, 27 June 2017 00:16 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 36219127286 for <quic-issues@ietfa.amsl.com>; Mon, 26 Jun 2017 17:16:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.019
X-Spam-Level:
X-Spam-Status: No, score=-7.019 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 97axk1TMAir4 for <quic-issues@ietfa.amsl.com>; Mon, 26 Jun 2017 17:15:58 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext7.iad.github.net [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6B4E91201F2 for <quic-issues@ietf.org>; Mon, 26 Jun 2017 17:15:58 -0700 (PDT)
Date: Mon, 26 Jun 2017 17:15:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1498522557; bh=QWoEBxNURdpixfM7ujXdTBEfUZTLCLncWsWphJPy5qw=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Wlza0TMR0qHTNO/afLaUaS4BF/IZa8iTsHvoK7xJmSKKyRRUUDBPfxhtjkw3XUKYA ijpUfbqC4rRVnVf8YbFd+OSDl0Z4JvAPG8Kt96GTUCQEZkZaaOR3FTKzPTXu9yOQXQ TjA4jdFmXGleaBFHvNW52zT0mcjZGqY0P7Ic1Tao=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab027ef4cb34e326bd21a2da097d2aaeb7ac43436992cf00000001156965bd92a169ce0e21ecbf@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/643/review/46417217@github.com>
In-Reply-To: <quicwg/base-drafts/pull/643@github.com>
References: <quicwg/base-drafts/pull/643@github.com>
Subject: Re: [quicwg/base-drafts] Unidirectional Streams (#643)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5951a3bdc2b0d_2c5313f918d12bc3c117046"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yhRLM_ooe8qo1Ec3_wdiN51aiXY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jun 2017 00:16:00 -0000
martinthomson commented on this pull request.
> @@ -401,6 +538,17 @@ All frames have the following format:
## Frame Definitions {#frames}
+### HAS_BODY {#frame-has-body}
+
+The HAS_BODY frame (type=0x0) indicates that the HTTP message contains a payload
+body. It is sent after the initial header block on a request, response, or push
+stream.
+
+The HAS_BODY frame has no flags and is always empty. A HAS_BODY frame with a
+non-empty payload or flags that are set MUST be treated as a
+HTTP_MALFORMED_HAS_BODY error.
I considered that, and it's definitely an optimization that we can talk about later, so I went with the simplest option I could think of. The problem with the header block is that there are potentially multiple places you would put this. The easiest approach is to grab a flag, but those appear in multiple places, so does this have to be consistent, or do you only allowing if END_HEADERS is also set, or can it appear on any HEADERS frame?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/643#discussion_r124152411
- [quicwg/base-drafts] Unidirectional Streams (#643) Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… MikkelFJ
- Re: [quicwg/base-drafts] Unidirectional Streams (… MikkelFJ
- Re: [quicwg/base-drafts] Unidirectional Streams (… MikkelFJ
- Re: [quicwg/base-drafts] Unidirectional Streams (… MikkelFJ
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… MikkelFJ
- Re: [quicwg/base-drafts] Unidirectional Streams (… MikkelFJ
- Re: [quicwg/base-drafts] Unidirectional Streams (… MikkelFJ
- Re: [quicwg/base-drafts] Unidirectional Streams (… Lucas Pardue
- Re: [quicwg/base-drafts] Unidirectional Streams (… Lucas Pardue
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Mark Nottingham
- Re: [quicwg/base-drafts] Unidirectional Streams (… Mike Bishop
- Re: [quicwg/base-drafts] Unidirectional Streams (… Mark Nottingham
- Re: [quicwg/base-drafts] Unidirectional Streams (… Mike Bishop
- Re: [quicwg/base-drafts] Unidirectional Streams (… ekr
- Re: [quicwg/base-drafts] Unidirectional Streams (… Christian Huitema
- Re: [quicwg/base-drafts] Unidirectional Streams (… Mike Bishop
- Re: [quicwg/base-drafts] Unidirectional Streams (… Christian Huitema
- Re: [quicwg/base-drafts] Unidirectional Streams (… Subodh Iyengar
- Re: [quicwg/base-drafts] Unidirectional Streams (… MikkelFJ
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Mike Bishop
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Mike Bishop
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson
- Re: [quicwg/base-drafts] Unidirectional Streams (… Martin Thomson