Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 15FF212006D
 for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 14:17:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level: 
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618,
 HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 2gkYZcL51AEN for <quic-issues@ietfa.amsl.com>;
 Tue, 29 Oct 2019 14:17:33 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id C6AE612001E
 for <quic-issues@ietf.org>; Tue, 29 Oct 2019 14:17:32 -0700 (PDT)
Date: Tue, 29 Oct 2019 14:17:31 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1572383851;
 bh=oBIWbVZY3t69MVgR7q/5j/KLhw/JrwoW2YBJvIi8bOQ=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=s1WOIhr4RXZlvRmBKzA1xu4WWc3G+KbanlpnMUg6YLFFfKAJuBD99lKxvDV6ObfJd
 PPoXZsSp9VZGt4AVhsHI8SVEfWVl7PlcI784wLlzpaG2MiFUGREtnUVAt38iu9r5ij
 Vakaagx0u8jzKmplTyjgAbpFEquXYK1AzaN1ut/s=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK7LPOEOXHTE3HMAEPF3YXWPXEVBNHHB45IKXM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3133/review/308840372@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3133@github.com>
References: <quicwg/base-drafts/pull/3133@github.com>
Subject: Re: [quicwg/base-drafts] Make language of representations consistent.
 (#3133)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5db8ac6bbd779_5f763f8aad2cd9641012c4";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yxW5VLORrR42VEDy_5C_8eZyP00>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 21:17:34 -0000


----==_mimepart_5db8ac6bbd779_5f763f8aad2cd9641012c4
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

afrind commented on this pull request.



> @@ -965,9 +965,8 @@ entry.
 
 ### Indexed Header Field
 
-An indexed header field representation identifies an entry in either the static
-table or the dynamic table and causes that header field to be added to the
-decoded header list.
+An indexed header field representation identifies an entry in the static table,
+or an entry in the dynamic table with an absolute index less than the Base.

We can tackle this in another PR.  This is all goodness so I'm merging now :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3133#discussion_r340330192
----==_mimepart_5db8ac6bbd779_5f763f8aad2cd9641012c4
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@afrind</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3133#discussion_r340330192">draft-ietf-quic-qpack.md</a>:</p>
<pre style='color:#555'>&gt; @@ -965,9 +965,8 @@ entry.
 
 ### Indexed Header Field
 
-An indexed header field representation identifies an entry in either the static
-table or the dynamic table and causes that header field to be added to the
-decoded header list.
+An indexed header field representation identifies an entry in the static table,
+or an entry in the dynamic table with an absolute index less than the Base.
</pre>
<p>We can tackle this in another PR.  This is all goodness so I'm merging now :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3133?email_source=notifications&amp;email_token=AFTOJK7ZELX3JGBIK5EJ6J3QRCR6XA5CNFSM4JDZZKV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJUIPNA#discussion_r340330192">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK2VIRYX45BAWEAO6SDQRCR6XANCNFSM4JDZZKVQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK64S6Z7IA5ASH52CHDQRCR6XA5CNFSM4JDZZKV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJUIPNA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3133?email_source=notifications\u0026email_token=AFTOJK7ZELX3JGBIK5EJ6J3QRCR6XA5CNFSM4JDZZKV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJUIPNA#discussion_r340330192",
"url": "https://github.com/quicwg/base-drafts/pull/3133?email_source=notifications\u0026email_token=AFTOJK7ZELX3JGBIK5EJ6J3QRCR6XA5CNFSM4JDZZKV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJUIPNA#discussion_r340330192",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5db8ac6bbd779_5f763f8aad2cd9641012c4--

