Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)

Martin Thomson <notifications@github.com> Tue, 08 January 2019 22:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C1871311D0 for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 14:38:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.447
X-Spam-Level:
X-Spam-Status: No, score=-6.447 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nLgCwJtiVlHQ for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 14:38:26 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B90FB1311C5 for <quic-issues@ietf.org>; Tue, 8 Jan 2019 14:38:25 -0800 (PST)
Date: Tue, 08 Jan 2019 14:38:24 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546987104; bh=W3F3IOPra0qwIbpCl12KmVNoi26095omzRKnejhC8YA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=I5jc2y4uFYyMchKBLc+GvJ3jOs2t/ATSO4T6CDxs9srRfe3P9TfoKun+42+KgfynI RJ2Uv/nCVDCFK+0q9hxdbQAWi8PmMlv/0RGjodvXwrqs7Gig6MSzFaD89yZwASPbqL LHXlCd7XYMySJ/4C5fTPn5sA7rB/Ysal7RpyS4Kw=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3dd7d3050429691121fd7ade00f73e8c1ca908c292cf00000001184ce86092a169ce1791b3a4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2285/c452477547@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2285@github.com>
References: <quicwg/base-drafts/pull/2285@github.com>
Subject: Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c352660b9acf_9433ffcbd2d45c01263e4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yxnqQ78J4LPa9PopHIvWjm7dHIc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 22:38:28 -0000

I'm not convinced that size > offset, but the other changes are a definite improvement.  Changing back to offset is easy enough.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2285#issuecomment-452477547