Re: [quicwg/base-drafts] Correcting polarity of SPA language (#2349)

Martin Thomson <notifications@github.com> Tue, 22 January 2019 23:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5ACB51311A5 for <quic-issues@ietfa.amsl.com>; Tue, 22 Jan 2019 15:47:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id niCnpZ5mCePV for <quic-issues@ietfa.amsl.com>; Tue, 22 Jan 2019 15:47:47 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 660281311A2 for <quic-issues@ietf.org>; Tue, 22 Jan 2019 15:47:47 -0800 (PST)
Date: Tue, 22 Jan 2019 15:47:46 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548200866; bh=sXCTdDIM4FOfNrUFHdje5vuHQxsZ739p8pFiY7VnWpY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=o3ADde6XCXyrWCwp4hQbXDqtayKRWN5TDolKZb3WQoR6A13XyyshCEdbBchbuEXrS paBvWBhiCkFzycVUvCWbpwiX35BtLGTFtMD4IDhS7q6rgtUR2+8Q3Noz6Trz+IYqtP OM1X6wHrpTzJhgaTRGu/m+IzQZ9K479BoRfz0j/8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab662cf467ffb310bcb6f33caad8c4ecf685cd24e092cf00000001185f6da292a169ce17e45777@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2349/review/195287960@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2349@github.com>
References: <quicwg/base-drafts/pull/2349@github.com>
Subject: Re: [quicwg/base-drafts] Correcting polarity of SPA language (#2349)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c47aba281045_7b623fd33ead45c0476d9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/z1njPumqfBC-5fTcabhqjrB_pVQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jan 2019 23:47:49 -0000

martinthomson commented on this pull request.



> @@ -2149,12 +2149,11 @@ MUST continue sending all future packets to the server's original IP address.
 A server might receive a packet addressed to its preferred IP address at any
 time after it accepts a connection.  If this packet contains a PATH_CHALLENGE
 frame, the server sends a PATH_RESPONSE frame as per {{migrate-validate}}.  The
-server MAY send other non-probing frames from its preferred address, but MUST
-continue sending all probing packets from its original IP address.
+server SHOULD send other non-probing frames from its original address until it
+receives a non-probing packet from the client at its preferred address.

```suggestion
receives a non-probing packet from the client at its preferred address and the server
has validated the new path.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2349#pullrequestreview-195287960