[quicwg/base-drafts] 82c82d: lost_pn can no longer be negative (#2621)

ianswett <noreply@github.com> Fri, 19 April 2019 19:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 21F22120391 for <quic-issues@ietfa.amsl.com>; Fri, 19 Apr 2019 12:46:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.001
X-Spam-Level:
X-Spam-Status: No, score=-7.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KrOtRbHSSJQ9 for <quic-issues@ietfa.amsl.com>; Fri, 19 Apr 2019 12:46:34 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 46CD41200B1 for <quic-issues@ietf.org>; Fri, 19 Apr 2019 12:46:34 -0700 (PDT)
Date: Fri, 19 Apr 2019 12:46:33 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555703193; bh=sT/EEVZ0KMvi8SklwvUxPXPQCKPzhzMeKGVD2oWjgGA=; h=Date:From:To:Subject:From; b=Q/UEVqn/z7aCzIgTd4sOPlk0xMxCo3WuIRC8zqdmQ0qiBk9Xu14OIqfrHtqLpwssU 8gRM6fNik67cNAp/EvyigDOvg9Hu0+zsQziNuTLF6F4QchlO/EiZaPifjxG6eRGSHF qiVf003El8VL1slbToVYGySJ6gTe7PchEnaSpV0g=
From: ianswett <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/ianswett-no-crypto-data/19ee6d-82c82d@github.com>
Subject: [quicwg/base-drafts] 82c82d: lost_pn can no longer be negative (#2621)
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/z9jPL5x06mLZltSwWFXoqZb9mu0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Apr 2019 19:46:36 -0000

  Branch: refs/heads/ianswett-no-crypto-data
  Home:   https://github.com/quicwg/base-drafts
  Commit: 82c82d533ab1e263e19391aa065acca5f9bceafe
      https://github.com/quicwg/base-drafts/commit/82c82d533ab1e263e19391aa065acca5f9bceafe
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2019-04-19 (Fri, 19 Apr 2019)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  lost_pn can no longer be negative (#2621)

* lost_pn can no longer be negative

And 0 is a valid packet number, so defaulting largest_acked_packet to 0 is inherently incorrect.

Fixes #2611

* Update draft-ietf-quic-recovery.md

Marten's suggestion

* Update draft-ietf-quic-recovery.md

Don't subtract

* Update draft-ietf-quic-recovery.md

* Update draft-ietf-quic-recovery.md