Re: [quicwg/base-drafts] Limit the size of packets (#501)

ianswett <notifications@github.com> Tue, 06 June 2017 15:55 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0F1FE129505 for <quic-issues@ietfa.amsl.com>; Tue, 6 Jun 2017 08:55:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.183
X-Spam-Level:
X-Spam-Status: No, score=-3.183 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M_evkccg9pqO for <quic-issues@ietfa.amsl.com>; Tue, 6 Jun 2017 08:55:55 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EA37C1286D6 for <quic-issues@ietf.org>; Tue, 6 Jun 2017 08:55:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=rdUeuZb1kxA8slr+H6ecO20a8Is=; b=pBz/4ZS/QB7hh1Cu iTHVzndZY2sn7/u1MKYiJ/uzZvE2ky0vYAeH6X/p0/y7kUSsAgP1Mj9GyyWp5K1P iWFpKmqlJ3BC9/MgFdTKPe3jILH9dxopfuQFojGD3GxPlYqe6iY3XrHwbFVPYxjX wQ93oSwUmwOXlmfjWi/wIr4tOx0=
Received: by filter0946p1mdw1.sendgrid.net with SMTP id filter0946p1mdw1-24544-5936D089-75 2017-06-06 15:55:53.908649433 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id CcjLXGFsTZCrhXFu6g-7PQ for <quic-issues@ietf.org>; Tue, 06 Jun 2017 15:55:53.833 +0000 (UTC)
Date: Tue, 06 Jun 2017 08:55:53 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab77d464bb3f3a7f5f7d7720be586883395d70a1ef92cf00000001154e928992a169ce0d7b300d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/501/review/42362013@github.com>
In-Reply-To: <quicwg/base-drafts/pull/501@github.com>
References: <quicwg/base-drafts/pull/501@github.com>
Subject: Re: [quicwg/base-drafts] Limit the size of packets (#501)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5936d0899c874_1d503fd01acafc2c953ec"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3w47z5ZemGw5xnRw1m8maBjfIhSMmSgtkCxZ YxGmlX17kJ3jPObIp/kUHml47ZEM1G08qJv3Rvy85pQI1IA/knsvuMBP6uk+kJxI/o32WWQbGBjEmc 3evTEli/JZZumBcgcQrYueAez3gWBgMxI9qQfU9F3uNzs2jyEGxcBKb6VLBwWJC54puUudmwTR5HOs g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zDZ9KiRUi8txkLbdSyXJNUcYDuY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jun 2017 15:55:58 -0000

ianswett approved this pull request.

I only left one comment, but with two issues, one of which was addressed with "This indicates that packets larger than this limit will be dropped" and the other was the 1252 change.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/501#pullrequestreview-42362013