Re: [quicwg/base-drafts] Rewrite text about Version Negotiation (#1039)

[MikkelFJ <[e-mail]>]

Nice work, C in pseudo code :)

It mostly looks good to me, except for where the client upgrades to the new version id:

> else if (tuple_matches && is_first_pkt && version_matches)
        use_new_conn_id()
        decrypt()

The client needs to use the new connection id only after it has got a connection id match. So it would be something along:
client:

```
In Client:
...
else /* long header */
    if (conn_id_matches)
        if (handshake_recent)
            if (version == 0)
                if (is_first_pkt)
                    process_VN();
                else
                    drop();
            else
                decrypt();
                if (got_new_conn_id)
                    use_new_conn_id()
        else
            drop();
    else
        drop()
```

Otherwise we are back to matching in tuples at one stage.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1039#issuecomment-358083675