Re: [quicwg/base-drafts] Be more specific when naming bits (#3089)

afrind <notifications@github.com> Wed, 16 October 2019 00:03 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 657A3120825 for <quic-issues@ietfa.amsl.com>; Tue, 15 Oct 2019 17:03:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MKM0mzC6UIdz for <quic-issues@ietfa.amsl.com>; Tue, 15 Oct 2019 17:03:33 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B85AD120019 for <quic-issues@ietf.org>; Tue, 15 Oct 2019 17:03:33 -0700 (PDT)
Date: Tue, 15 Oct 2019 17:03:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571184213; bh=zDO0Qk1H3WMSlovlxN8teGK3ufYQVNUoUiK950nJpQE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kQi3xN/hXazvnyHidoKFRuchQeo0gQvLy59dt7bXkfj3tWSTfsW2QhcrgUyZukh9Z mg+OxGcY2R0uk7sui9PDopijdo6l7un5H1ng9+yIBuFn6P9vZmZgHSQq77PeW/n+fz 2APpYuprE/LH87/lX4v5wI7s1iBbYDuXqMwc8bBo=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2W74N4UDG4GQYJCNV3WOPOJEVBNHHB4LNBAY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3089/review/302261196@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3089@github.com>
References: <quicwg/base-drafts/pull/3089@github.com>
Subject: Re: [quicwg/base-drafts] Be more specific when naming bits (#3089)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da65e54e9af3_1c983feea24cd96810785c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zNwV069D8v-pLaj03I1ApTQMOow>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2019 00:03:36 -0000

afrind commented on this pull request.



> @@ -682,10 +682,10 @@ acknowledged as this instruction does not insert an entry.
 An encoder adds an entry to the dynamic table where the header field name
 matches the header field name of an entry stored in the static or the dynamic
 table using an instruction that starts with the '1' one-bit pattern.  The second
-(`S`) bit indicates whether the reference is to the static or dynamic table. The
+('T') bit indicates whether the reference is to the static or dynamic table. The

I'm fine with T.  T=1 -> Static is a little weird I guess, but you can just think about it as the sTatic table bit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3089#discussion_r335228599