IETF Logo Mail Archive

Re: [quicwg/base-drafts] Split error code space (#722)

Mike Bishop <notifications@github.com> Thu, 07 September 2017 17:09 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D747B132D82 for <quic-issues@ietfa.amsl.com>; Thu, 7 Sep 2017 10:09:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.401
X-Spam-Level:
X-Spam-Status: No, score=-0.401 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IwYhV6vSBAiV for <quic-issues@ietfa.amsl.com>; Thu, 7 Sep 2017 10:09:26 -0700 (PDT)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 56420132992 for <quic-issues@ietf.org>; Thu, 7 Sep 2017 10:09:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=PykYAEN0JNlb3yxvTEfzAPzaerM=; b=rjdMKZA4cXTvJFZs 90fLzv9FMsCBIGM/fsy/G5iOuuNZQF0hU9xdGkx+6LaYMva3LdCRsMNlixo9cDVS 56TGPMVU0UpDAVEvX9ZMNU0FS8S5hVPRB1JXe6GyynkZ8MMRqgft6/AbdE1YZeY5 dh2PqUrbWqQZ+sg18p2nG8A7mgE=
Received: by filter0828p1mdw1.sendgrid.net with SMTP id filter0828p1mdw1-13234-59B17D0A-4F 2017-09-07 17:08:26.71653287 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0038p1mdw1.sendgrid.net (SG) with ESMTP id wFlhlwj7S-SThKB68unelA for <quic-issues@ietf.org>; Thu, 07 Sep 2017 17:08:26.379 +0000 (UTC)
Date: Thu, 07 Sep 2017 17:08:49 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba71379aa2907a2e403acf235cb1057f32b8acda292cf0000000115c93d5392a169ce0edfabce@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/722/review/61286145@github.com>
In-Reply-To: <quicwg/base-drafts/pull/722@github.com>
References: <quicwg/base-drafts/pull/722@github.com>
Subject: Re: [quicwg/base-drafts] Split error code space (#722)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59b17b53d908e_13f0d3f8470b0dc34924f0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak39LfFGzDcvE0PQ/DImSw0CHYNvRkwlvu+cTj w1ImWNjABO89qsSmoVL6X4B7HtLy7mK0k92MumV6I7NsLNw/28Cpl7X+7Be9YvA7srsJpNDGyln60d iLNQ2SzCMQZUItqFA6nEMB1xOoJhUKgDqTwkkRKzVhfglu8p5g3CXP88M0mNKvTNJZTxIjncMpYoAm o=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zOQn4FN_V2YG8Y5GdHp0Q-Voj30>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Sep 2017 17:09:28 -0000

MikeBishop commented on this pull request.

Change looks fine.

> @@ -1067,7 +1070,7 @@ The HTTP/2 error codes defined in Section 7 of {{!RFC7540}} map to QUIC error
 codes as follows:
 
 NO_ERROR (0x0):
-: QUIC_NO_ERROR
+: HTTP_NO_ERROR

"...in {{http-error-codes}}." for consistency with the others.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/722#pullrequestreview-61286145

v2.46.0 | Report a Bug | By Email | System Status