Re: [quicwg/base-drafts] QPACK [editorial] Misc minor editorial changes. (#2942)

Bence Béky <> Wed, 31 July 2019 17:01 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 87D1712051D for <>; Wed, 31 Jul 2019 10:01:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.381
X-Spam-Status: No, score=-6.381 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.001, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id 0XUfdWOZouIf for <>; Wed, 31 Jul 2019 10:01:47 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id F1F4D1204C3 for <>; Wed, 31 Jul 2019 10:01:46 -0700 (PDT)
Date: Wed, 31 Jul 2019 10:01:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1564592506; bh=IykRaPtZ0PST/Muq7t+jAMiv7rYQIu+rIkt0m0z8apk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=j0wsb2DaKS+A8RO7szk4BJrQEPXF577TXKbA6BJho9uV9krKHB8u4RQ320H5pCFYA NqDeu+m2KAJ94GEaeFHhdjOise8qNAGTE7oGltqwuiC8NIfUJOpPThNg9d6634BEjY EVdOr5Gly69O5+Z193VkTlQp33rZKKoNCGx9NHnQ=
From: =?UTF-8?B?QmVuY2UgQsOpa3k=?= <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2942/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] QPACK [editorial] Misc minor editorial changes. (#2942)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d41c97a1e89e_39693f853b0cd960131267"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 31 Jul 2019 17:01:49 -0000

bencebeky commented on this pull request.

> @@ -445,19 +443,23 @@ encoder sends a Set Dynamic Table Capacity instruction
 ({{set-dynamic-capacity}}) with a non-zero capacity to begin using the dynamic
-Before a new entry is added to the dynamic table, entries are evicted from the

I am not aware of any reason the specs need to require an implementation to evict first, then add.  Spelling out a choice also allows the caution on use-after-free to be restricted to one of the two methods.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: