Re: [quicwg/base-drafts] Add OnPacketReceived to pseudocode (#3653)

Jana Iyengar <notifications@github.com> Tue, 19 May 2020 02:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C8A03A10CA for <quic-issues@ietfa.amsl.com>; Mon, 18 May 2020 19:44:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.081
X-Spam-Level:
X-Spam-Status: No, score=0.081 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.282, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 67KyClNu_dTC for <quic-issues@ietfa.amsl.com>; Mon, 18 May 2020 19:44:30 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7BB1F3A108C for <quic-issues@ietf.org>; Mon, 18 May 2020 19:44:30 -0700 (PDT)
Received: from github-lowworker-d1d6e31.ash1-iad.github.net (github-lowworker-d1d6e31.ash1-iad.github.net [10.56.105.50]) by smtp.github.com (Postfix) with ESMTP id AB8479602AF for <quic-issues@ietf.org>; Mon, 18 May 2020 19:44:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589856268; bh=qOtsOE1aTsotdKuUkfVHL2hg7A+46pIkD9eqzF+ubHE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=S0EqwV0/FjXoJoF0zMX4RiMvo8qITG/Mt3v5EfQ132X+amwpm0wIMLcsCICjVLwRq uPVKdTXUzdeDvwKZrlWQYKwYqnhUGkvvO5KbKHyVu03bdgfgimzwXQjZyMmMQT5F7Q Rej1/0m5+qYJsyVM7VWEjNdjvux/UUZtqobh4+bY=
Date: Mon, 18 May 2020 19:44:28 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7KCPMYFFO5OWIA3ZV4Z4UQZEVBNHHCJTOADM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3653/review/414060771@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3653@github.com>
References: <quicwg/base-drafts/pull/3653@github.com>
Subject: Re: [quicwg/base-drafts] Add OnPacketReceived to pseudocode (#3653)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec3480c9a7a7_45a33fbb444cd968960db"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zYdw9jsXO5F5e18mgYA8MR2T-kc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2020 02:44:32 -0000

@janaiyengar commented on this pull request.



> +Receiving a datagram might allow the server to send if the
+server was previously blocked by the anti-amplification limits.
+This is necessary even if none of the packets in the datagram
+are successfully processed.

```suggestion
When a server is  blocked by anti-amplification limits, receiving
a datagram unblocks it, even if none of the packets in the datagram
are successfully processed. In such a case, the PTO timer is now set,
since data is in flight and probes can be sent.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3653#pullrequestreview-414060771