Re: [quicwg/base-drafts] Add an enum indicating the timer_mode (#3182)

Marten Seemann <notifications@github.com> Sat, 02 November 2019 01:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5C555120B48 for <quic-issues@ietfa.amsl.com>; Fri, 1 Nov 2019 18:36:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V6gysevXS64A for <quic-issues@ietfa.amsl.com>; Fri, 1 Nov 2019 18:36:45 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4E1F120144 for <quic-issues@ietf.org>; Fri, 1 Nov 2019 18:36:32 -0700 (PDT)
Received: from github-lowworker-d31a065.va3-iad.github.net (github-lowworker-d31a065.va3-iad.github.net [10.48.17.70]) by smtp.github.com (Postfix) with ESMTP id 0B0D76604D3 for <quic-issues@ietf.org>; Fri, 1 Nov 2019 18:36:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572658592; bh=iqz7OXO+vVEFuj2bIPTnfzOxmZb9O7hWiBOHwbASzjw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eecMcD6nTQ5yzxdV9PlOhBos4XsmpJIP/GTTjEBiOcZYonTEMYp2XuXqWR5KGESw1 1OStWEN94mGHOgYZcOkZzfmBctge0vzG7BPExl1IqPh1+2v5kNtTX64qYnM0r4bHEe rcCJB4a35/q7YfgBDhAeNkDlenKGjjbQaaxZckwc=
Date: Fri, 01 Nov 2019 18:36:31 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZOJU6ER6KBEGVOC5N3ZIIB7EVBNHHB5RLS4Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3182/c548998009@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3182@github.com>
References: <quicwg/base-drafts/pull/3182@github.com>
Subject: Re: [quicwg/base-drafts] Add an enum indicating the timer_mode (#3182)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dbcdd9fef244_27983f970c0cd964538b6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zid0gU4-tjvO19XBhv66eJ8dQns>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Nov 2019 01:36:46 -0000

@ianswett Thanks for the PR! I was planning to submit a PR myself to fix the issue I raised, but I got sidetracked by other stuff.

Don't we also need a timer mode for the amplification limit on the client side?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3182#issuecomment-548998009