Re: [quicwg/base-drafts] Unnecessary packet number expectations in ACK frame description (#3310)

Dmitri Tikhonov <notifications@github.com> Fri, 27 December 2019 15:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6769A12006F for <quic-issues@ietfa.amsl.com>; Fri, 27 Dec 2019 07:58:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id obNIVLF1kFrV for <quic-issues@ietfa.amsl.com>; Fri, 27 Dec 2019 07:58:23 -0800 (PST)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BA94C120019 for <quic-issues@ietf.org>; Fri, 27 Dec 2019 07:58:23 -0800 (PST)
Date: Fri, 27 Dec 2019 07:58:23 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1577462303; bh=Xd3VmNi7YKXnvqSf6XnCsff/YqbpxaCiwKe2amTRFSI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bEEK4IMddXacOXEkyLkj+PMQ85dWpXu+4vOL5hrTdBUFmT+58XDwvV4vQFS4os+LI NYxz8QRQ2G+PDYXd3mkiQoij7JvE8vV2ywN4Q1XlDCEMrmu125DIaMCjG0En9hTFP9 PewefUEyogVIiy6mc26ne0WsvAvMgHIQwYNi5Cw4=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4GQBHL6J3AON2223F4CNOJ7EVBNHHCAXBUGE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3310/569296381@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3310@github.com>
References: <quicwg/base-drafts/issues/3310@github.com>
Subject: Re: [quicwg/base-drafts] Unnecessary packet number expectations in ACK frame description (#3310)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e062a1f1421e_5573fdfe76cd96c3073e1"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zkaO9Ak6lcQijRKeBZ7audMbuY0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Dec 2019 15:58:26 -0000

The second sentence can stand some improvement as well:
1. There is no need for the word "only."
1. It is not necessary to say that the ACK frame was received.
1. Packets, not packet numbers, are acknowledged.

How about something like this:
> An ACK frame acknowledges packets in the same packet number space as the packet in which it is contained.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3310#issuecomment-569296381