IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make the ack-tracking examplary (#3979)

Mike Bishop <notifications@github.com> Mon, 10 August 2020 15:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 13F403A169A for <quic-issues@ietfa.amsl.com>; Mon, 10 Aug 2020 08:10:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iAB_hEoU89bQ for <quic-issues@ietfa.amsl.com>; Mon, 10 Aug 2020 08:10:51 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D93953A1698 for <quic-issues@ietf.org>; Mon, 10 Aug 2020 08:10:51 -0700 (PDT)
Received: from github-lowworker-d93c4b6.va3-iad.github.net (github-lowworker-d93c4b6.va3-iad.github.net [10.48.17.47]) by smtp.github.com (Postfix) with ESMTP id A59FD5E0093 for <quic-issues@ietf.org>; Mon, 10 Aug 2020 08:10:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597072250; bh=HXBZ9CTHjrQxaAGighfLTa4wmXMkrZDm4QRwimJhTJ8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uSr6hi+XCvgAgwXdivTDZGKxPSNY+lu2hLbNcT5hxcV3wh0Qb3VXKoTScRGQVMMgm 7FyN5rW+IJ/WWJCPqoasJuoup8tyiP0iLy6pr6QOaYhWjoJidCrtfDTquwTy5OXvjZ aP8GzlpsqXYPCUKi0BjjORQHiAIoKzdzl//Y+300=
Date: Mon, 10 Aug 2020 08:10:50 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3QW2C4JZPMIQXBPIN5HVCHVEVBNHHCQD3SRM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3979/review/464318361@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3979@github.com>
References: <quicwg/base-drafts/pull/3979@github.com>
Subject: Re: [quicwg/base-drafts] Make the ack-tracking examplary (#3979)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f31637a93afd_63d116f81079e4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zm1uE1Pe_TWS16hx2h8mxnuX3g4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2020 15:10:53 -0000

@MikeBishop approved this pull request.



> @@ -3666,17 +3644,33 @@ validation at a sender and including a lower value than what was included in a
 previous ACK frame could cause ECN to be unnecessarily disabled; see
 {{ecn-validation}}.
 
+{{ack-tracking}} describes an exemplary approach for determining what packets
+to acknowledge in each ACK frame.  Though the goal of this algorithm is to
+generate an acknowledgment for every packet that is processed, it is still
+possible for acknowledgments to be lost.  A sender cannot expect to receive

Minor nit; I think the sender is right to expect this in the normal case, but it's not guaranteed and can't be relied upon.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3979#pullrequestreview-464318361

v2.23.0 | Report a Bug | By Email