Re: [EXTERNAL] Re: WGLC review of draft-ietf-quic-recovery-29

Ian Swett <ianswett@google.com> Mon, 20 July 2020 16:48 UTC

Return-Path: <ianswett@google.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5CBCD3A0D2B for <quic@ietfa.amsl.com>; Mon, 20 Jul 2020 09:48:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.599
X-Spam-Level:
X-Spam-Status: No, score=-17.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W777DWnYwVeI for <quic@ietfa.amsl.com>; Mon, 20 Jul 2020 09:48:50 -0700 (PDT)
Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8B5E33A0D29 for <quic@ietf.org>; Mon, 20 Jul 2020 09:48:50 -0700 (PDT)
Received: by mail-yb1-xb2d.google.com with SMTP id v9so8613808ybe.3 for <quic@ietf.org>; Mon, 20 Jul 2020 09:48:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oa2lcPQgB0VT0mdwAhEC51ZTuRUqd2ZnlO1EsPo2Plg=; b=DZaocirvouGvM/jdz13YvGp5aQ6Hw1w8MBKS4HjSK6ud3Qsj9rwj5kxcAhprb1JU5d DPOOPcFMMsPVkHxMIswhM0TlXLX8FJhPlFrupIhlpoWHZiFGOfBByXCMoLeryXmEgysI mR6uGhBO52ZgwxM7GLambHNCsg4dR6chIH3NLi9liCY32booZndFv9M5/S9VQ9nbhq6g eMQ7jraAcqE9fzAsaKiL81Z7ldG2q4V6ZUD5/Vsjurj3cyRoVShXOItE2vMC/s7zhDtf IeaFiyZ2vEtCYVqbRo4jKb5RrMxSKQsFI6comSLzSxE/swBaIZKj0nnTNizvz8Tnexlt vy3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oa2lcPQgB0VT0mdwAhEC51ZTuRUqd2ZnlO1EsPo2Plg=; b=PZDvDt3o9/iuL+Whps4u2zhP7taf5wIZDTm73X9F+z1EyXANec1v4BSzcGHOE/VbZS sve5dH5EK/worqXy0EHt1NlkHli7y7THB7VRIcrgr+UI+DmEfEfpw9YW+L/F/L+FATmW aUycjJNRrwAGIU86CPIuLXFzHgpFvgR4ij5S39z3dDjkGLO4dv/Q4glGwKeHXm6yqF5c OIEFbBOQxuh9ribTmbr+LoYkpzR2yPTWW6TVTB/ut0/DSQUVtP9HDnUiB8VQWVmzp8Tv mC9Mq0fPyV33V2i5XZ8Kljd8oRFS26eQleAdpZIuF8pdgWojNj/rUwk+OaeyVpzOtvnv GIzg==
X-Gm-Message-State: AOAM532x+8nYAtYZ05ZzmOqKxTsodwhBpGOfVCIefb5Y7u3l01VIZQKt 7MOBdP9vKUohP//82Xu13Wgm5FS+pM6sAHE6yQFSNA==
X-Google-Smtp-Source: ABdhPJwj1uHY2GSjaR86JG8pUsaeHgcvmPqCIFsodb3pj1VYb/TpxkT5V71w+xoIo2UVRyG3KIouelaHrdO4l6b0PDY=
X-Received: by 2002:a25:ba8c:: with SMTP id s12mr33887589ybg.278.1595263729377; Mon, 20 Jul 2020 09:48:49 -0700 (PDT)
MIME-Version: 1.0
References: <MN2PR00MB073663726DB5AFE6885D0A6BB6670@MN2PR00MB0736.namprd00.prod.outlook.com> <9f57b20d-2eba-b2b9-d8c8-48e019c8952a@wizmail.org> <CACpbDccrpHeP5PYGCZky+AN2gC9YSs5gbAzYr4Yrw1LpvHZNiA@mail.gmail.com> <CH2PR00MB07269A73542DBC8E51E95519B67A0@CH2PR00MB0726.namprd00.prod.outlook.com>
In-Reply-To: <CH2PR00MB07269A73542DBC8E51E95519B67A0@CH2PR00MB0726.namprd00.prod.outlook.com>
From: Ian Swett <ianswett@google.com>
Date: Mon, 20 Jul 2020 12:48:37 -0400
Message-ID: <CAKcm_gMhRX3NxiW6Primy+UrY44ZahaSO+9kF5CeeN4=XqL2JQ@mail.gmail.com>
Subject: Re: [EXTERNAL] Re: WGLC review of draft-ietf-quic-recovery-29
To: Praveen Balasubramanian <pravb=40microsoft.com@dmarc.ietf.org>
Cc: Jana Iyengar <jri.ietf@gmail.com>, QUIC WG <quic@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000ea1d2e05aae2477d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/6RHGGjQjOQqchYWFr4bwZQCFnRE>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jul 2020 16:48:53 -0000

I think it's ok to include burst limits in the set of things we expect may
be different in DCs, but if we do that, I'd prefer to use the RECOMMENDED
rather than SHOULD, since there are a number of SHOULDs which I
believe apply both to the public internet and to DCs.  Then we could add a
note at the top about how there are some values which are RECOMMENDED,
including X, Y and Z, and those recommendations are expected to be good
choices for most, but not all environments.

In terms of text, I'd suggest taking Neal's suggestion and dropping an
explicit mention of the public internet:

Implementations MUST either use pacing or another method to limit such bursts.

It is RECOMMENDED that implementations limit bursts to the initial
congestion window; see Section 7.2
<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftools.ietf.org%2Fhtml%2Fdraft-ietf-quic-recovery-29%23section-7.2&data=02%7C01%7Cpravb%40microsoft.com%7C9df3e5f4f0ca4e586f0908d824e0a3ad%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637299894526657906&sdata=ze%2F7SpKUbrdgwI6m%2BS6uEGSBgc2NapVtPn9vkOYFjVs%3D&reserved=0>.


On Sun, Jul 19, 2020 at 4:08 PM Praveen Balasubramanian <pravb=
40microsoft.com@dmarc.ietf.org> wrote:

> >> There's a way of satisfying both desires: have the NIC handle the
> pacing.
>
> Yes letting the NIC handle pacing will make improve CPU efficiency and
> improve accuracy due to fine grained hardware timers. But that’s in the
> future. Today’s NICs don’t pace large send offloads for TCP or UDP.
>
>
>
> >> Perhaps we can have a principle here: recommendations that are specific
> for Internet use are just that, and we use SHOULDs for those. IW10 makes
> sense based on this, and I would then also be fine with changing the MUST
> to a SHOULD. Perhaps we can state this principle upfront.
>
> I like the idea of stating that principle up front. SHOULD would be
> sufficient resolution for the burst size issue.
>
>
>
> *From:* QUIC <quic-bounces@ietf.org> *On Behalf Of * Jana Iyengar
> *Sent:* Friday, July 17, 2020 7:18 PM
> *To:* QUIC WG <quic@ietf.org>
> *Subject:* [EXTERNAL] Re: WGLC review of draft-ietf-quic-recovery-29
>
>
>
> There's a protocol question and there's a question of endpoint behavior.
> In terms of the protocol itself, yes, there's no real need to distinguish
> between Internet and DC environments; we've tried to ensure that the
> protocol can be used broadly. My point was that the constants in the spec
> were based on what we believe to be true for the public Internet, and not
> for DC environments.
>
>
>
> That said, perhaps I was a bit too hasty. IW10 and InitialRTT values are
> the others I was thinking about, but those are recommendations in the spec,
> not requirements. And as Ian notes, there's no minimum timeout anymore.
>
>
>
> Perhaps we can have a principle here: recommendations that are specific
> for Internet use are just that, and we use SHOULDs for those. IW10 makes
> sense based on this, and I would then also be fine with changing the MUST
> to a SHOULD. Perhaps we can state this principle upfront.
>
>
>
> Ian, I share your hesitation that we don't want to make a distinction
> between private and public networks, but we already allow for
> implementations to do that with a different IW and Initial RTT. Is it
> different when talking about burst limits?
>
>
>
>
>
> On Fri, Jul 17, 2020 at 3:07 PM Jeremy Harris <jgh@wizmail.org> wrote:
>
> On 08/07/2020 22:29, Praveen Balasubramanian wrote:
> > Section 7.9
> > "Implementations MUST either use pacing or another method to limit such
> bursts to the initial congestion window; see Section 7.2."
> > This seems to preclude use of segmentation offload of sizes greater than
> IW.. In datacenters we routinely send bursts that are higher without
> causing loss. The MUST here seems unnecessary. It also conflicts with the
> RECOMMENDED in an earlier sentence.
>
> There's a way of satisfying both desires: have the NIC handle the
> pacing.
> --
> Cheers,
>   Jeremy
>
>