Re: Second WGLC for QUIC Acknowledgement Frequency

Gorry Fairhurst <gorry@erg.abdn.ac.uk> Mon, 06 May 2024 17:21 UTC

Return-Path: <gorry@erg.abdn.ac.uk>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 62F55C14F604 for <quic@ietfa.amsl.com>; Mon, 6 May 2024 10:21:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SFCU8SAm_08v for <quic@ietfa.amsl.com>; Mon, 6 May 2024 10:21:09 -0700 (PDT)
Received: from pegasus.erg.abdn.ac.uk (pegasus.erg.abdn.ac.uk [137.50.19.135]) by ietfa.amsl.com (Postfix) with ESMTP id C61CDC14F68A for <quic@ietf.org>; Mon, 6 May 2024 10:21:07 -0700 (PDT)
Received: from [192.168.1.130] (fgrpf.plus.com [212.159.18.54]) by pegasus.erg.abdn.ac.uk (Postfix) with ESMTPSA id A17001B0022C for <quic@ietf.org>; Mon, 6 May 2024 18:21:04 +0100 (BST)
Message-ID: <4876d3cc-daeb-4d8d-94fb-547a895fcedb@erg.abdn.ac.uk>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Second WGLC for QUIC Acknowledgement Frequency
Content-Language: en-GB
To: quic@ietf.org
References: <f8354a52-17fc-4055-a29c-824295edc158@app.fastmail.com>
From: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
Organization: UNIVERSITY OF ABERDEEN
In-Reply-To: <f8354a52-17fc-4055-a29c-824295edc158@app.fastmail.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Message-ID-Hash: RCT6UQCQHFZXBDCPWBWLXM2KYQNXGTOH
X-Message-ID-Hash: RCT6UQCQHFZXBDCPWBWLXM2KYQNXGTOH
X-MailFrom: gorry@erg.abdn.ac.uk
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-quic.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.9rc4
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/AYxHvokBxJ1W_HJrKF7awQsCy8E>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Owner: <mailto:quic-owner@ietf.org>
List-Post: <mailto:quic@ietf.org>
List-Subscribe: <mailto:quic-join@ietf.org>
List-Unsubscribe: <mailto:quic-leave@ietf.org>
Date: Tue, 21 May 2024 17:26:21 -0000
X-Original-Date: Mon, 6 May 2024 18:21:04 +0100

On 03/05/2024 01:00, Lucas Pardue wrote:
 > Hi folks,
 >
 > The document authors have recently published 09 of 
draft-ietf-quic-ack-frequency [1]. This address feedback received during 
the last WGLC and leaves us with zero open issues or pull requests.
 >
 > We're running a second, shorter, WGLC to give folks an opportunity to 
review the entire changeset before progressing document. It commences 
now and concludes on Friday May 10 2024 anywhere on earth.
 >
 > Please direct feedback as issues on the github repository at
 > https://github.com/quicwg/ack-frequency.
 >
 > Cheers
 > Lucas & Matt
 > QuIC WG Chairs
 >
 >
 > [1] - https://datatracker.ietf.org/doc/draft-ietf-quic-ack-frequency/

I've read -09, the changes seem fine to me, I think this is ready to 
progress, but I do have some editorial comments (mainly on the new text):

1. The text says:

        “it leaves the determination of how
         frequently to send acknowledgments in response to ack-eliciting
         packets to the data receiver, without any ability for the data 
sender
         to impact this behavior.”

- This new sentence construction includes two “to”s. That seems rather 
clumsy, could we rewrite without one of them, such as:

“the data receiver determines how
         frequently to send acknowledgments in response to ack-eliciting
         packets, without any ability for the data sender
         to impact this behavior.”
--

2. The text says "impact" twice:
“to impact this behavior.”
- Is impact correct? is this better as /influence/ or /guide/ or /control/
(This also appears later as: “without any ability for the data sender to 
impact”...)
--


3. The text says: "high bandwidth connections".

- I do not think that this is really about the path /bandwidth/ ... 
isn’t this actually the application rate, so ought it to be high-rate 
connections?
--

4. The text says:
"of packet 10 needs to trigger another immediate ACK because only with
the reporting of the successful receiption of packet 10, the sender
will be able to declare packet 7 as lost (with a reordering threshold"
- This was an awkward read, and also includes a typo. Could this be 
something like:

"of packet 10 needs to trigger another immediate ACK, because
the sender will be unable to declare packet 7 as lost (with a reordering 
threshold
of 3) until it receives an ACK reporting the reception of packet 10."
--

5. The text says:
"if multiple CE-marked packets are received in a row"
- I am not sure what is intended by "in a row",  would it be clearer as 
this or something else?:
"if multiple consecutive CE-marked packets are received?"

--

Best wishes,


Gorry