IETF Logo Mail Archive

Re: PRIORITY stream error?

Ryan Hamilton <rch@google.com> Wed, 06 March 2019 21:31 UTC

Return-Path: <rch@google.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6AF7C12D84D for <quic@ietfa.amsl.com>; Wed, 6 Mar 2019 13:31:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.501
X-Spam-Level:
X-Spam-Status: No, score=-17.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jxeNAgIFkR0j for <quic@ietfa.amsl.com>; Wed, 6 Mar 2019 13:31:21 -0800 (PST)
Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4991F126F72 for <quic@ietf.org>; Wed, 6 Mar 2019 13:31:21 -0800 (PST)
Received: by mail-wm1-x32e.google.com with SMTP id f65so7324452wma.2 for <quic@ietf.org>; Wed, 06 Mar 2019 13:31:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tf4hCC/pzAmSWeV6aXm4E9FF5OHC/1xlWIyyWl+hi50=; b=OjcdtdGhpxHweqsRG800o4B5AMb7eezg9RltOJBxV3ricTok9cpDfWDtDuY7DzImzK 3S/qca246/Is74+Ho8wwcmNxp6BaxNdOqLfFI8pcK90PkiHnZLhHik4p88WP2q94JIXI tZwVVLTvc3KPGAYnkRGPHR2aiy6jd+dsyzV+gTmXUQe9bhz8Y4jHOEcCeQuT6Kwp1N5m 793KM+nZ2FHrokLv9JtTM+Vb/+NweYFVdng3cIvGDyeJMIrUq3ZcdBEm/aFfEN/nbDqQ nfCxNEsCNrj3+86eWgtnfy5iLgS536Hc084MOxhkDVUKGvKKdu1mKjNXYeGFUT47Y1Nt a72w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tf4hCC/pzAmSWeV6aXm4E9FF5OHC/1xlWIyyWl+hi50=; b=kfkLzKeY4qouYzxP/r0DkYhSnPSxfCYRdnZ+FXlu56FbX0yNiOHqpfqO1eSka85I0n pF7IMl8hjDmneikQPvo63P7lxS8W62kySZZb0iGZAgkgcxWHeViXz5dowDVXGnJQnsxG BbZo3c59ThcflzFLKnaiZQ2b1G5iNQH0rDwjE6Oqt9HDL1XQ3ZZOvbIxeeeKrHa0WD7I /jCPoT0VjvKdxbcq9nJ29niKLwqE5y7pipsfMI7DPiMTzPkYBMZweSWYEkCuagIZihlr a30ya1baxOBYCqUn+8W0y9bEBuZNWgvv1+T4yogQZ+VdpX7q8XtxvlM9NONVJcSRz8Wr 2h8A==
X-Gm-Message-State: APjAAAV6JA+nbEf1OmCS4MGSW5R2bVGfxdP4eE+OL5NE9+gXTopMrsN2 PSrzkk7F+wDpRWc7JFHz+H9tMPskMKZP9vgt2SY+sQ==
X-Google-Smtp-Source: APXvYqyABjOg/VXaNv2gxC5YyB6d3eJ+21p7AEXO/5fWKCcHUQOGnGAFnD4j2A5aJhJ5Edtsju/qBanvW4FbIfXfnmY=
X-Received: by 2002:a1c:9693:: with SMTP id y141mr3792417wmd.33.1551907879314; Wed, 06 Mar 2019 13:31:19 -0800 (PST)
MIME-Version: 1.0
References: <CAM4esxRy-F5xjdQxc1sNt4atr840DtD9Z=L8nBUE-jvDZ9154w@mail.gmail.com> <CALGR9oafBn0OEBFOsjzBbBwN8SxxEg8GuoG1kXTNL+yMdyr12w@mail.gmail.com>
In-Reply-To: <CALGR9oafBn0OEBFOsjzBbBwN8SxxEg8GuoG1kXTNL+yMdyr12w@mail.gmail.com>
From: Ryan Hamilton <rch@google.com>
Date: Wed, 06 Mar 2019 13:31:06 -0800
Message-ID: <CAJ_4DfTnjH18QF-9r6kO+AhQkETi0o-iMOaeg+hCxn1MBcOULQ@mail.gmail.com>
Subject: Re: PRIORITY stream error?
To: Lucas Pardue <lucaspardue.24.7@gmail.com>
Cc: Martin Duke <martin.h.duke@gmail.com>, QUIC WG <quic@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000df63f9058373b504"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/_Bt68dEaIA6hslnyEnNLpHW-V8g>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 21:31:24 -0000

I agree with Martin on this; it smells like a connection error. Making this
a stream error in order to collect more details doesn't seem terribly
useful, and in any case, the endpoint could stuff more info (like the
stream id) into the reason phrase field.

On Wed, Mar 6, 2019 at 1:27 PM Lucas Pardue <lucaspardue.24.7@gmail.com>
wrote:

> Hey Martin,
>
> On Wed, 6 Mar 2019, 20:59 Martin Duke, <martin.h.duke@gmail.com> wrote:
>
>> the very end of Section 4.2.3 of quic-http says:
>>
>>    PRIORITY frames received by a client MUST be treated as a stream
>>    error of type HTTP_UNEXPECTED_FRAME.
>>
>>
>> Elsewhere, this kind of thing is a connection error. Making this a
>> stream error seems problematic; if otherwise valid, if this goes out on the
>> control stream a stream error may bring everything down anyway?
>>
>> Should this be a connection error, or am I missing something?
>>
>
> My thinking is that if you send this in a RESET_STREAM  the other endpoint
> knows what stream the offending was sent on. Just getting this in
> CONNECTION close is quite a broad error.
>
> Also note that endpoints are free to treat stream errors as connection
> errors Iif they want, so you can go straight to that route if you want.
>
> Cheers
> Lucas
>
>>

v2.23.0 | Report a Bug | By Email