Re: PRIORITY stream error?

Roberto Peon <fenix@fb.com> Wed, 06 March 2019 23:40 UTC

Return-Path: <prvs=8968f5ff83=fenix@fb.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB8781310F7 for <quic@ietfa.amsl.com>; Wed, 6 Mar 2019 15:40:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.234
X-Spam-Level:
X-Spam-Status: No, score=-1.234 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KHOP_DYNAMIC=1.468, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fb.com header.b=V7O2QjnP; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.b=dX75yFbU
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yQW_ToTdEYbt for <quic@ietfa.amsl.com>; Wed, 6 Mar 2019 15:40:45 -0800 (PST)
Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E68E812008A for <quic@ietf.org>; Wed, 6 Mar 2019 15:40:44 -0800 (PST)
Received: from pps.filterd (m0109331.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x26NX2XH029984; Wed, 6 Mar 2019 15:40:44 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=4JCpXjZW9J/v733rVCZaRAFm97YadZjp4PIqy31W5Rs=; b=V7O2QjnP52ZsCMKwt04DdN8b9tLOgnM7O9bYmBgGCqMvx4M+IZhMewtauC1hpsINvg5A 06CpXY1QJyWn76pFHnjd7tP8Rqkt4QKPD1GeC5XMciqEPVEo1LkDCzSVZu9En7dlZbpW 65h3mV6/Is76e5qS1iIIAj9fXs4vTxeKLXk=
Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2r2puw08b6-8 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 06 Mar 2019 15:40:44 -0800
Received: from prn-hub03.TheFacebook.com (2620:10d:c081:35::127) by prn-hub02.TheFacebook.com (2620:10d:c081:35::126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5; Wed, 6 Mar 2019 15:40:21 -0800
Received: from NAM01-BN3-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5 via Frontend Transport; Wed, 6 Mar 2019 15:40:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4JCpXjZW9J/v733rVCZaRAFm97YadZjp4PIqy31W5Rs=; b=dX75yFbUKOryOYL9C9YwWoMl66JhgG61SW1G7Av6oMJsHy65ooGQctZzmQu6IcAIyyFbcqKWoVVBf5X2LylMRyq145jduBzSvubrD3K0QSr6/wOUZC6pfYmRCpILfxyYBcGlghEhxdb4DI5NenZQwrkqZLb7dicH3Q2zfAYNhZs=
Received: from BYAPR15MB2312.namprd15.prod.outlook.com (52.135.197.146) by BYAPR15MB2456.namprd15.prod.outlook.com (52.135.200.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.19; Wed, 6 Mar 2019 23:40:20 +0000
Received: from BYAPR15MB2312.namprd15.prod.outlook.com ([fe80::9d7b:c4a4:e46c:ab71]) by BYAPR15MB2312.namprd15.prod.outlook.com ([fe80::9d7b:c4a4:e46c:ab71%8]) with mapi id 15.20.1665.021; Wed, 6 Mar 2019 23:40:20 +0000
From: Roberto Peon <fenix@fb.com>
To: Martin Thomson <mt@lowentropy.net>, "quic@ietf.org" <quic@ietf.org>
Subject: Re: PRIORITY stream error?
Thread-Topic: PRIORITY stream error?
Thread-Index: AQHU1F+WVOvWiQkjvk2d3ZArAJIni6X/MVsAgAAB9QD//4m+gA==
Date: Wed, 06 Mar 2019 23:40:19 +0000
Message-ID: <AD911A49-4F70-43E5-BF95-02ECA5411291@fb.com>
References: <CAM4esxRy-F5xjdQxc1sNt4atr840DtD9Z=L8nBUE-jvDZ9154w@mail.gmail.com> <CANatvzxghmoCbrVEYw6BkLt99-i8p+AfNnaqnbeR6m8TkuZBeA@mail.gmail.com> <207a34cc-8b35-4944-9eb3-1661930686ce@www.fastmail.com>
In-Reply-To: <207a34cc-8b35-4944-9eb3-1661930686ce@www.fastmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.16.1.190220
x-originating-ip: [2620:10d:c090:200::6:a040]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fa9a3ecd-f344-4887-4bb8-08d6a28d183f
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BYAPR15MB2456;
x-ms-traffictypediagnostic: BYAPR15MB2456:
x-microsoft-exchange-diagnostics: 1; BYAPR15MB2456; 20:sCMkuED9x1/ebqgZGtzpAcm7+PS/2moYsjRzWPsIfwWlaoT+Y4n1jGI9FZ6lAdT+ChArwH8IDAG8O76hZ6BOm6lWOoiOvHvfVjS7OizUoiLMY9ESYGmr5Yaal9/TaB/gLmvl4vDwtY1txfZ0mF/tdv54gBolzHDWtEKBF7WpTJE=
x-microsoft-antispam-prvs: <BYAPR15MB2456866EC403587A3D64E82ACD730@BYAPR15MB2456.namprd15.prod.outlook.com>
x-forefront-prvs: 0968D37274
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(376002)(346002)(396003)(136003)(39860400002)(189003)(199004)(51444003)(83716004)(110136005)(8936002)(316002)(7116003)(2906002)(58126008)(186003)(6116002)(81156014)(81166006)(68736007)(71200400001)(8676002)(3480700005)(82746002)(71190400001)(6512007)(76176011)(105586002)(6246003)(53936002)(106356001)(6506007)(2501003)(6486002)(99286004)(14444005)(6436002)(5660300002)(2616005)(305945005)(46003)(97736004)(446003)(11346002)(102836004)(229853002)(256004)(486006)(476003)(7736002)(25786009)(36756003)(14454004)(86362001)(478600001)(33656002); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR15MB2456; H:BYAPR15MB2312.namprd15.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: xDCdKV22u7jmLsBwdvtvPZGff/Le/o49MwbYJ1I0ucdUQFsLGsC7iQM+CZmfDgWpGiYMjXICDt7wn6ScqDX7ImclzQsfYg0rlstz9tFEz+j573900t7s2FbX9zflUna04bNu9Ju1SoMMsN1s8vxe/u2m6P5wRC25npfBhZv6n/kgKUlVgUR9ZUaihjWXRwWwZcj2wJ7cfxH8sUJkd0KG9seyHA3EmecukyZHZiIwnzrhEQF0MlNnkq/7YxacWeeHuH7LYvza97QGwYpDI9J++49Rfs4or7VpEIorLatSr0clUN8W+Jxv5p/Fnk0+lb0JyuLFyTUxGm4NFIftwJjMY9wtvkJa8mgF4ibK1PXGYPXM8wWkV8M8aUjFUr/PiP1rCNCpQw7xwq8v68RaUik5HjQwgQufzWMijdq8MlrhSdQ=
Content-Type: text/plain; charset="utf-8"
Content-ID: <53A82CB435343445975BB117A98B081A@namprd15.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fa9a3ecd-f344-4887-4bb8-08d6a28d183f
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 23:40:19.8592 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2456
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-06_16:, , signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/huK_6DiAsnJkhgHvW5iMFdKaT-k>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 23:40:46 -0000

As a general principal (sometimes violated):
If the behavior can be deterministically known to be incorrect, it should probably be a connection error.

In cases where the behavior cannot deterministically be known to be correct (e.g. because of races/timing), it should not be a connection error.

It seems like being "brutal" when possible (as per above) achieves the best interop.
-=R

On 3/6/19, 2:44 PM, "QUIC on behalf of Martin Thomson" <quic-bounces@ietf.org on behalf of mt@lowentropy.net> wrote:

    This view (that the error is localized) is one that we took in HTTP/2.  In retrospect, I don't think that it has been used as much as you would think.  It is far easier to treat violations of spec brutally.  Indeed, this tends to make the problem more visible, which is a good thing.
    
    On Thu, Mar 7, 2019, at 09:37, Kazuho Oku wrote:
    > 2019年3月7日(木) 5:59 Martin Duke <martin.h.duke@gmail.com>:
    > >
    > > the very end of Section 4.2.3 of quic-http says:
    > >
    > >    PRIORITY frames received by a client MUST be treated as a stream
    > >    error of type HTTP_UNEXPECTED_FRAME.
    > >
    > >
    > > Elsewhere, this kind of thing is a connection error.
    > 
    > I am not sure if I agree with the observation. IIUC, the general
    > approach is to use stream errors when the error does not affect the
    > entire connection.
    > 
    > It is reasonable for a client to respond with a stream error when it
    > observes a PRIORITY frame on a *request* stream.
    > 
    > That said, I agree that it should be a connection error when the
    > client receives a PRIORITY frame on a control frame. That's because we
    > cannot have a stream-level error for a control stream, because the
    > stream can never be closed. I think that's what is missing in the
    > text.
    > 
    > FWIW, we do have this "if the error is X then it's a stream-level
    > error, or if the error is Y then it's a connection-level error" type
    > of handling. See section 3.2.2 for an example.
    > 
    > > Making this a  stream error seems problematic; if otherwise valid, if this goes out on the control stream a stream error may bring everything down anyway?
    > >
    > > Should this be a connection error, or am I missing something?
    > 
    > 
    > 
    > -- 
    > Kazuho Oku
    > 
    >