Re: PRIORITY stream error?

Ian Swett <ianswett@google.com> Wed, 06 March 2019 21:34 UTC

Return-Path: <ianswett@google.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 19DA9131209 for <quic@ietfa.amsl.com>; Wed, 6 Mar 2019 13:34:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.5
X-Spam-Level:
X-Spam-Status: No, score=-17.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wiafpTfsMuZW for <quic@ietfa.amsl.com>; Wed, 6 Mar 2019 13:34:42 -0800 (PST)
Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6FD07131162 for <quic@ietf.org>; Wed, 6 Mar 2019 13:34:42 -0800 (PST)
Received: by mail-wm1-x333.google.com with SMTP id x7so7359647wmj.0 for <quic@ietf.org>; Wed, 06 Mar 2019 13:34:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iokAd4W90rveqlfKlurvw33sHzoZK4grJE8hYxHDGwM=; b=cKARpeAZN/A8edtV2hw0sluuOTEMNwEtQkScmC0ktncZWTU+rBKzhlGbwEi053EZ/E Ixa1YM94qm7BtHMg9RdBMo5mrenFni6CEshxVq6dSzUflYwN0tqPRzYoGChhKjQqvb4C AgGUgIcrMBJpfZOKjK8it6eM2FThfOaNQjlXRAb61NkKZzrYylirmjj5hC+/NpnFwnWa k6GCzwHR63aMsN9kElcUJlAJlNUE8POMG3fOf6oD9+hvC4cupWQPcsLX8xKIv/7cWtWS gW/bsC7oacplsNWmiujM8CNf1mXxqlTE1paEidBt5vU51dfPiy0irIZ635k1cD0/T0q4 c6Jg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iokAd4W90rveqlfKlurvw33sHzoZK4grJE8hYxHDGwM=; b=L5OyHBADIuDv4JQTCkF+Jw9eOzO26O2BWvqENqSPm5YrxqJ/bH7ug20Irn50bEJZFI 7fFIbLQO12d81jmzEjxE0GJyIuGwHw7mjIhUAB3dGNvo+1XXYVDrsNANykcPupoi2t2n 7YX4U4pAb/2PZBqRVRrq/CmHbotsNoSfjuJWPg6B3bExbgjg/qgOF/4C+S4cYgBN1lPn hUEr/FZrBt3nnqFuMR0KjYV1aP0g8YuNtUWigiUDKg4i4sIlBnpGuRtIiUrTFg6tFphQ TL5gBdAMebyh6dkDsmGCMbIZnmSi6DdglgprxGy/N3s0Mtm3Wr/6AmzZIQdAXG8xymYp hVDQ==
X-Gm-Message-State: APjAAAW5pdx8O70kGFOaYCpaPezTrB5XYfH1zi68tLpc+2ivDWZZVWCF bTWTWbQqTyIrufuPCt/Z6rO4tu4S3yG450CMdo011Q==
X-Google-Smtp-Source: APXvYqxsDOdlBHOOq4Ls+FoVZIbWhbz9y8UNqHDAy7RapY0p7NXQJGcBQ9LB0MdpbOA6KckYmh3OewKzAwlZZ+6M2lE=
X-Received: by 2002:a1c:f502:: with SMTP id t2mr3569928wmh.124.1551908080744; Wed, 06 Mar 2019 13:34:40 -0800 (PST)
MIME-Version: 1.0
References: <CAM4esxRy-F5xjdQxc1sNt4atr840DtD9Z=L8nBUE-jvDZ9154w@mail.gmail.com> <CALGR9oafBn0OEBFOsjzBbBwN8SxxEg8GuoG1kXTNL+yMdyr12w@mail.gmail.com> <CAJ_4DfTnjH18QF-9r6kO+AhQkETi0o-iMOaeg+hCxn1MBcOULQ@mail.gmail.com>
In-Reply-To: <CAJ_4DfTnjH18QF-9r6kO+AhQkETi0o-iMOaeg+hCxn1MBcOULQ@mail.gmail.com>
From: Ian Swett <ianswett@google.com>
Date: Wed, 06 Mar 2019 16:34:29 -0500
Message-ID: <CAKcm_gP048mx53hTXC6Cbg18vfgfMqU4hyD3CzaFfaMR0rdJpQ@mail.gmail.com>
Subject: Re: PRIORITY stream error?
To: Ryan Hamilton <rch=40google.com@dmarc.ietf.org>
Cc: Lucas Pardue <lucaspardue.24.7@gmail.com>, QUIC WG <quic@ietf.org>, Martin Duke <martin.h.duke@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000e0e47d058373c1cb"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/mtXpyGuaDwN4JGJqomGxuHdEhVs>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 21:34:54 -0000

Recently in transport(Issue #2487
<https://github.com/quicwg/base-drafts/issues/2487>), members of the
working group have favored fatal connection close errors over accepting
questionable values, so I agree that this should be a connection close
error.

On Wed, Mar 6, 2019 at 4:31 PM Ryan Hamilton <rch=
40google.com@dmarc.ietf.org> wrote:

> I agree with Martin on this; it smells like a connection error. Making
> this a stream error in order to collect more details doesn't seem terribly
> useful, and in any case, the endpoint could stuff more info (like the
> stream id) into the reason phrase field.
>
> On Wed, Mar 6, 2019 at 1:27 PM Lucas Pardue <lucaspardue.24.7@gmail.com>
> wrote:
>
>> Hey Martin,
>>
>> On Wed, 6 Mar 2019, 20:59 Martin Duke, <martin.h.duke@gmail.com> wrote:
>>
>>> the very end of Section 4.2.3 of quic-http says:
>>>
>>>    PRIORITY frames received by a client MUST be treated as a stream
>>>    error of type HTTP_UNEXPECTED_FRAME.
>>>
>>>
>>> Elsewhere, this kind of thing is a connection error. Making this a
>>> stream error seems problematic; if otherwise valid, if this goes out on the
>>> control stream a stream error may bring everything down anyway?
>>>
>>> Should this be a connection error, or am I missing something?
>>>
>>
>> My thinking is that if you send this in a RESET_STREAM  the other
>> endpoint knows what stream the offending was sent on. Just getting this in
>> CONNECTION close is quite a broad error.
>>
>> Also note that endpoints are free to treat stream errors as connection
>> errors Iif they want, so you can go straight to that route if you want.
>>
>> Cheers
>> Lucas
>>
>>>