Re: adjusted_rtt

Lars Eggert <lars@eggert.org> Thu, 08 April 2021 08:15 UTC

Return-Path: <lars@eggert.org>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 87D0F3A3FAD for <quic@ietfa.amsl.com>; Thu, 8 Apr 2021 01:15:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bYNic87CcCyz for <quic@ietfa.amsl.com>; Thu, 8 Apr 2021 01:15:31 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5BA4D3A3FAC for <quic@ietf.org>; Thu, 8 Apr 2021 01:15:31 -0700 (PDT)
Received: from [IPv6:2a00:ac00:4000:400:758e:dc44:2359:672d] (unknown [IPv6:2a00:ac00:4000:400:758e:dc44:2359:672d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id C2E82600314; Thu, 8 Apr 2021 11:15:22 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1617869722; bh=wEWTVzRV3jMMcOEAKuSfTD/H8LfSnSeTTK1oi/9Ysvk=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=Yvm8lZwsUIu0kf+ri1iKXxp9QQAsOfM3ezLaaaxWcyAXTZocD7pz18azt6XbLCm16 2S2PiXXN6KmO5eQLTtmxVcCdx4VIo+H2PgyKrP8Y7c1ClzHypT2YGAsCYzNilSUjZd h+6mHdQxChLwIq2/w+tviN/bGVI+J4kXjzwi9Yj0=
From: Lars Eggert <lars@eggert.org>
Message-Id: <BDAE42A6-17E8-4EC3-A722-51B132B679FB@eggert.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_01B06DC1-D36D-4173-A972-80AF7174BBB8"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: adjusted_rtt
Date: Thu, 08 Apr 2021 11:15:22 +0300
In-Reply-To: <32445F64-13D6-4999-AE61-91350D06F02B@fh-muenster.de>
Cc: IETF QUIC WG <quic@ietf.org>
To: Timo Völker <timo.voelker@fh-muenster.de>
References: <32445F64-13D6-4999-AE61-91350D06F02B@fh-muenster.de>
X-Mailer: Apple Mail (2.3654.60.0.2.21)
X-MailScanner-ID: C2E82600314.A1C14
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/pjU-PtmYZ5TauK2QwkqM7DCJFU8>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2021 08:15:37 -0000

I created https://github.com/quicwg/base-drafts/issues/4860 to track this.

Thanks,
Lars


> On 2021-4-7, at 20:22, Timo Völker <timo.voelker@fh-muenster.de> wrote:
> 
> Hi,
> 
> I noticed in a simulation with a constant RTT that the smoothed_rtt value includes the ack_delay. It looks like my implementation follows the recovery draft. By looking closer, I believe I found a tiny error in the draft.
> 
> Section 5.3 contains this sentence.
> 
> "MUST NOT subtract the acknowledgment delay from the RTT sample if the resulting value is smaller than the min_rtt."
> 
> I interpret this as do not subtract ack_delay from latest_rtt if
> 
>  latest_rtt - ack_delay < min_rtt
> 
> Or to say the inverse, substract ack_delay from latest_rtt if
> 
>  latest_rtt - ack_delay >= min_rtt
>  <==> latest_rtt >= min_rtt + ack_delay
>  <==> min_rtt + ack_delay <= latest_rtt
> 
> The pseudo code in Section 5.3 and in the appendix use a smaller instead of an equal or smaller in the if statement.
> 
>  if (min_rtt + ack_delay < latest_rtt):
> 
> It should be <= or did I miss something?
> 
> Timo