Re: [radext] I-D Action: draft-ietf-radext-tls-psk-01.txt

[Fabian Mauchle <[e-mail]>]

Hi All,

On 08.08.23 19:41, [e-mail] wrote:
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories. This Internet-Draft is a work item of the RADIUS EXTensions
> (RADEXT) WG of the IETF.
> 
>     Title           : RADIUS and TLS-PSK
>     Author          : Alan DeKok
>     Filename        : draft-ietf-radext-tls-psk-01.txt
>     Pages           : 12
>     Date            : 2023-08-08

I've read new -01 and this looks quite good to me.

A few more cosmetic things:

* Section 4.1.1
The introductory sentence mentions both client and server, but the 
requirements list only states client. Just to avoid, confusion:

 > *  no shared secret is used for more than one RADIUS client or server
 > *  no PSK is used for more than one RADIUS client or server

* Section 6.1
 > This section describes current practices and mandates behavior for
 > servers which use TLS-PSK.
I think this sentence is out of place since section 6.1 describes the 
current practice, while section 6.2 (and 6.2.1) describes the mandates.

Since Section 6 already introduces this, just remove that one sentence.

* Section 6.2, paragraph 4
 > connections from a source network of 192.0.2/24
Use proper CIDR notation as per BCP122: 192.0.2.0/24

Regards,
Fabian

-- 
Fabian Mauchle, Network

SWITCH
Werdstrasse 2, P.O. Box, 8021 Zurich, Switzerland
Phone [phone], direct [phone]