Re: [radext] [Technical Errata Reported] RFC5090 (5115)
Alan DeKok <aland@deployingradius.com> Fri, 15 September 2017 14:52 UTC
Return-Path: <aland@deployingradius.com>
X-Original-To: radext@ietfa.amsl.com
Delivered-To: radext@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ACCFE133343 for <radext@ietfa.amsl.com>; Fri, 15 Sep 2017 07:52:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OVFioJv4f2dQ for <radext@ietfa.amsl.com>; Fri, 15 Sep 2017 07:52:31 -0700 (PDT)
Received: from mail.networkradius.com (mail.networkradius.com [62.210.147.122]) by ietfa.amsl.com (Postfix) with ESMTP id E90441331C2 for <radext@ietf.org>; Fri, 15 Sep 2017 07:52:30 -0700 (PDT)
Received: from [192.168.10.50] (CPEf4cc55220745-CM64777ddff610.cpe.net.cable.rogers.com [99.248.225.186]) by mail.networkradius.com (Postfix) with ESMTPSA id 86144DA; Fri, 15 Sep 2017 14:52:28 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alan DeKok <aland@deployingradius.com>
In-Reply-To: <CAHw9_iL-FZLDcwyYCTpp=a-2TB9RKKmE96iAEAigxu3dzTtj4A@mail.gmail.com>
Date: Fri, 15 Sep 2017 10:52:26 -0400
Cc: radext@ietf.org, "lionel.morand@orange.com" <lionel.morand@orange.com>, Winter Stefan <stefan.winter@restena.lu>, dscreat@dscreat.com, dwilli@cisco.com, baruch@kayote.com, denis@ovsienko.info, beckw@t-systems.com, Benoit Claise <bclaise@cisco.com>, david@kayote.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <0ADDAA9A-1DFB-49E0-9F45-01668CF5F531@deployingradius.com>
References: <20170914200740.335AEB80D6B@rfc-editor.org> <CAHw9_iL-FZLDcwyYCTpp=a-2TB9RKKmE96iAEAigxu3dzTtj4A@mail.gmail.com>
To: Warren Kumari <warren@kumari.net>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/radext/Pqwk8Fw-3SNygmPU5v9e2U6BApc>
X-Mailman-Approved-At: Sun, 17 Sep 2017 22:14:34 -0700
Subject: Re: [radext] [Technical Errata Reported] RFC5090 (5115)
X-BeenThere: radext@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: RADIUS EXTensions working group discussion list <radext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/radext>, <mailto:radext-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/radext/>
List-Post: <mailto:radext@ietf.org>
List-Help: <mailto:radext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/radext>, <mailto:radext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Sep 2017 14:52:32 -0000
On Sep 15, 2017, at 9:44 AM, Warren Kumari <warren@kumari.net> wrote: > > I'm not a RADIUS person, and I'd like some advice / feedback here - > from my brief reading of RFC5090 (and RFC4590) and a twisty maze of > references, which seemed to end at RFC 7616 is does look like > Digest-Domain is indeed a (unbounded) string, and so I think that the > errata is correct for at least that part. Yes. > It also seems that Digest-Stale is a string, but should only be 'true' > or 'false' and so should likely be >=6 (4 chars for 'true' + type + > length), but I'd assume that >=3 is likely better, because otherwise > someone is likely to trip over pointy parser edges (e.g if someone > decided to return 'x' instead of 'true' I think that this should be a > failure somewhere other than in the parser). I agree. The RADIUS specs are usually fairly vague. But using "== 3" in a place where it everything else uses ">= 3" is definitely wrong. Alan DeKok.
- [radext] [Technical Errata Reported] RFC5090 (511… RFC Errata System
- Re: [radext] [Technical Errata Reported] RFC5090 … Warren Kumari
- Re: [radext] [Technical Errata Reported] RFC5090 … Alan DeKok