Re: [radext] Adoption of draft-cheng-radext-ip-port-radius-ext-00.txt ?

Alan DeKok <aland@deployingradius.com> Wed, 23 April 2014 20:37 UTC

Return-Path: <aland@deployingradius.com>
X-Original-To: radext@ietfa.amsl.com
Delivered-To: radext@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0DA421A0650 for <radext@ietfa.amsl.com>; Wed, 23 Apr 2014 13:37:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.001
X-Spam-Level:
X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[BAYES_40=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yPtqZJceYhBo for <radext@ietfa.amsl.com>; Wed, 23 Apr 2014 13:37:13 -0700 (PDT)
Received: from power.freeradius.org (power.freeradius.org [88.190.25.44]) by ietfa.amsl.com (Postfix) with ESMTP id CF8211A064C for <radext@ietf.org>; Wed, 23 Apr 2014 13:37:11 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by power.freeradius.org (Postfix) with ESMTP id 87BEC2240602; Wed, 23 Apr 2014 22:37:03 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at power.freeradius.org
Received: from power.freeradius.org ([127.0.0.1]) by localhost (power.freeradius.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8GPmkN8RfKag; Wed, 23 Apr 2014 22:36:56 +0200 (CEST)
Received: from Thor.local (unknown [64.229.83.96]) by power.freeradius.org (Postfix) with ESMTPSA id 7F27C2240050; Wed, 23 Apr 2014 22:36:54 +0200 (CEST)
Message-ID: <53582465.1040701@deployingradius.com>
Date: Wed, 23 Apr 2014 16:36:53 -0400
From: Alan DeKok <aland@deployingradius.com>
User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228)
MIME-Version: 1.0
To: Stefan Winter <stefan.winter@restena.lu>
References: <5357B645.5050105@restena.lu>
In-Reply-To: <5357B645.5050105@restena.lu>
X-Enigmail-Version: 0.96.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Archived-At: http://mailarchive.ietf.org/arch/msg/radext/rsWlQbqT_Jr3kJ07hxuxceLq_WY
Cc: "radext@ietf.org" <radext@ietf.org>
Subject: Re: [radext] Adoption of draft-cheng-radext-ip-port-radius-ext-00.txt ?
X-BeenThere: radext@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: RADIUS EXTensions working group discussion list <radext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/radext>, <mailto:radext-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/radext/>
List-Post: <mailto:radext@ietf.org>
List-Help: <mailto:radext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/radext>, <mailto:radext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Apr 2014 20:37:15 -0000

Stefan Winter wrote:
> This mail starts a two week call for adoption for this draft. Please
> reply to this mail indicating whether you are in favour for adoption or
> not. Since the discussions in London were of generic nature, and not
> directly asking for adoption, there is no default - silence does not
> count as acceptance. So don't be silent :-)

  I support adoption.

  On a quick review of the document, there are still outstanding issues.
 These issues are around field sizes, data types, etc.  These issues
could be solved by referencing the "data types" draft.  However, that
draft isn't a WG item, and isn't on the charter.

- IP-Port-Type should be "integer" not "one octet"

- IP-Port-Limit TLVs should be "integer", and not "16-bit integer".  I'm
also not sure why this needs a TLV

- IP-Port-Range should be multiple sub-TLVs, instead of one TLV with
binary packed data

- IP-Port-Forwarding-Map has the same comment as above

  The rest of the document seems clear in it's intent, design, and
execution.

  Alan DeKok.