Re: [Rats] I-D Action: draft-ietf-rats-eat-20.txt

Carsten Bormann <cabo@tzi.org> Sat, 17 June 2023 12:27 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: rats@ietfa.amsl.com
Delivered-To: rats@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 912B4C1519AF for <rats@ietfa.amsl.com>; Sat, 17 Jun 2023 05:27:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.895
X-Spam-Level:
X-Spam-Status: No, score=-1.895 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FTmM6qlE8d-4 for <rats@ietfa.amsl.com>; Sat, 17 Jun 2023 05:27:11 -0700 (PDT)
Received: from smtp.zfn.uni-bremen.de (smtp.zfn.uni-bremen.de [IPv6:2001:638:708:32::21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CB71EC151B1F for <rats@ietf.org>; Sat, 17 Jun 2023 05:27:09 -0700 (PDT)
Received: from [192.168.217.124] (p548dc15c.dip0.t-ipconnect.de [84.141.193.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4QjwJV6RRpzDCbT; Sat, 17 Jun 2023 14:27:06 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <168669220478.20924.5666203131876501501@ietfa.amsl.com>
Date: Sat, 17 Jun 2023 14:27:06 +0200
X-Mao-Original-Outgoing-Id: 708697626.521018-c807f78684f31d0c227b53414db1f0b7
Content-Transfer-Encoding: quoted-printable
Message-Id: <F12D8D6D-563A-45F6-A09F-73BF96BF9E9F@tzi.org>
References: <168669220478.20924.5666203131876501501@ietfa.amsl.com>
To: rats@ietf.org
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rats/H8qXwQywD0W6x4QcC9Iwd5LYl2s>
Subject: Re: [Rats] I-D Action: draft-ietf-rats-eat-20.txt
X-BeenThere: rats@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Remote ATtestation procedureS <rats.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rats>, <mailto:rats-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rats/>
List-Post: <mailto:rats@ietf.org>
List-Help: <mailto:rats-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rats>, <mailto:rats-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Jun 2023 12:27:13 -0000

I’m not following this draft closely, but I have a quick editorial comment:

Section 2 (terminology) defines the term "Base64url Encoding”, referencing RFC 4648 as well as RFC 7515 to fill in the open questions from RFC 4648.

So far, so good.

This term is then never used.

A term "base64url encoded” (or [correct] variant spelling “base64url-encoded”) is used in multiple places.  One of the places restates its own reference to RFC 4648, but doesn’t restate the reference to RFC 7515 and the text required with that.  This restatement is very misleading as it strongly implies RFC 7515 is *not* used here; the reference needs to be removed.  In the other places I find the term is simply used, which assumes the reader will think to look up the term in the terminology and make the match with the different term.  An internal cross-reference might help.

Grüße, Carsten


> On 2023-06-13, at 23:36, internet-drafts@ietf.org wrote:
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories. This Internet-Draft is a work item of the Remote ATtestation
> ProcedureS (RATS) WG of the IETF.
> 
>   Title           : The Entity Attestation Token (EAT)
>   Authors         : Laurence Lundblade
>                     Giridhar Mandyam
>                     Jeremy O'Donoghue
>                     Carl Wallace
>   Filename        : draft-ietf-rats-eat-20.txt
>   Pages           : 100
>   Date            : 2023-06-13
> 
> Abstract:
>   An Entity Attestation Token (EAT) provides an attested claims set
>   that describes state and characteristics of an entity, a device like
>   a smartphone, IoT device, network equipment or such.  This claims set
>   is used by a relying party, server or service to determine how much
>   it wishes to trust the entity.
> 
>   An EAT is either a CBOR Web Token (CWT) or JSON Web Token (JWT) with
>   attestation-oriented claims.
> 
> The IETF datatracker status page for this Internet-Draft is:
> https://datatracker.ietf.org/doc/draft-ietf-rats-eat/
> 
> There is also an htmlized version available at:
> https://datatracker.ietf.org/doc/html/draft-ietf-rats-eat-20
> 
> A diff from the previous version is available at:
> https://author-tools.ietf.org/iddiff?url2=draft-ietf-rats-eat-20
> 
> Internet-Drafts are also available by rsync at rsync.ietf.org::internet-drafts
> 
>