Re: [Rats] Some Feedback on CHARRA

["Eric Voit (evoit)" <[e-mail]>]

Hi William,

Thanks very much for the suggestions.  Thoughts in-line...

> From: William Bellingrath, September 16, 2020 8:39 PM
> 
>  Hi all,
> 
> We have been discussing the CHARRA yang module, and I would like to float
> back some feedback and recommendations from my colleagues.
> Comments are predominantly aimed at naming conventions, or ease of reading,
> and are just suggestions.
> 
> 
> 1.
> module ietf-tpm-remote-attestation {
>   namespace "urn:ietf:params:xml:ns:yang:ietf-tpm-remote-attestation";
>   prefix "tpm";
> 
>   import ietf-yang-types {
>     prefix yang;
>   }
>   import ietf-hardware {
>     prefix ietfhw;
>   }
>   import ietf-keystore {
>     prefix ks;
>   }
>   import ietf-tcg-algs {
>     prefix taa;
>   }
> Recommend these prefix names changed to something easier to read.

IETF YANG conventions are to have short prefixes.  As noted in RFC 8407, Section 4.2:
"Prefix values SHOULD be short but are also likely to be unique."

This was recently revalidated in an IESG review:

https://mailarchive.ietf.org/arch/msg/sfc/miYTals3g56kSV34Igrm83Pw_Xg/
"Prefix ietf-pot-profile is cumbersome - 3-5 characters is more than
enough for a prefix"

> 2.
> ...
> must "/tpm:rats-support-structures/tpm:attester-supported-algos"
>          + "/tpm:tpm20-asymmetric-signing";  ...
> 
> Recommend adding an error message or description with the “must”
> statements.

This makes sense.   I have added.   

> 3. For all identity naming, recommend using '-' instead of '_'.
> E.x. grouping TPM2_Algo, grouping TPM12_Algo, etc

Change made for all identities in CHARRA using '-'.    

> 4.
>       leaf revMajor {
> …
>       leaf revMinor {
> …
> Recommend renaming these to ‘rev-major’ and ‘rev-minor’

Change made.

Current state of YANG model based on your suggestions above is in a pull request at:
https://github.com/ietf-rats-wg/basic-yang-module/pull/16/commits

Eric

> Thanks,
> William Bellingrath
> 
> 
> Juniper Business Use Only