From nobody Tue Dec  7 03:49:29 2021
Return-Path: <Hannes.Tschofenig@arm.com>
X-Original-To: rats@ietfa.amsl.com
Delivered-To: rats@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 40B7C3A1572
 for <rats@ietfa.amsl.com>; Tue,  7 Dec 2021 03:49:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.891
X-Spam-Level: 
X-Spam-Status: No, score=-1.891 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01,
 UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=armh.onmicrosoft.com header.b=rn2etc0y;
 dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com
 header.b=rn2etc0y
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id jGZUs1CjCuiO for <rats@ietfa.amsl.com>;
 Tue,  7 Dec 2021 03:49:22 -0800 (PST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr40055.outbound.protection.outlook.com [40.107.4.55])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id A19AA3A1570
 for <rats@ietf.org>; Tue,  7 Dec 2021 03:49:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; 
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C2d5SbB0gGCeI/m53gKNq2Ey8IpAubWrtI+2S3wn08M=;
 b=rn2etc0yLvFVuw5fLqjSjlkIhYtf27wAICaijUchIcC9YJkX+iyvdfH/Ag1WNOjC7Y/Zq5E/FTkrs10o7dGJLAUua4GF3QjUoal/yUaNP2ZkQcWEHkF2PbWLOgSCui/dyyB5lYtN/67h76SllmudhWBsD4wZ4BpOvdCXKQPH+0M=
Received: from AS8PR04CA0002.eurprd04.prod.outlook.com (2603:10a6:20b:310::7)
 by DBAPR08MB5735.eurprd08.prod.outlook.com (2603:10a6:10:1a1::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Tue, 7 Dec
 2021 11:49:20 +0000
Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:310:cafe::b1) by AS8PR04CA0002.outlook.office365.com
 (2603:10a6:20b:310::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Tue, 7 Dec 2021 11:49:19 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Tue, 7 Dec 2021 11:49:19 +0000
Received: ("Tessian outbound 1cd1a01725a6:v110");
 Tue, 07 Dec 2021 11:49:19 +0000
X-CR-MTA-TID: 64aa7808
Received: from f5027a3b78f7.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4FF69E1F-BAB0-4D39-A81E-DC9D486EFC1F.1; 
 Tue, 07 Dec 2021 11:49:13 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f5027a3b78f7.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 07 Dec 2021 11:49:13 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ml11BwwkHREUpcSfe7k1/ZaqrU3c2f7vyLzyzP5wuwYU+7aKnqk8WBJxLW87eO2Wt7XRNniMgz8sIW98fKVzW7m/oG76fsHYa4yHvYH6hq8D+gQTVZWsrTlknyRalUA3+hV/tqUKtWum8hy+PoJjNmrmZ3/Lv4c3EMQf00qd77ykN3e5BnymAmsj9BHxnRDKMD0Y93p0iQBdMGi3ZAI6K1NdFqLFSoKKzq7sZnlyhOUlUgqyVskV3NnySKMJH0STJbtnoechOD2+GPaUVmA6o+8hESuQFNUKcBoLvAdyI0g/0P80inQb5corkR2bHgEHTK0mvYrGqhyyZxQh3tOGkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=C2d5SbB0gGCeI/m53gKNq2Ey8IpAubWrtI+2S3wn08M=;
 b=lRxgydenY77w21cB7d/PAKM6ZUEfxBkPM0NVEyZ2R/auO+JqP9nlZKqPugu1hwDbRy5qkQwdhI/GQAK7ZFB3KGRD2iViXSAi4Ffg7cPxbqG6aYykQdX8XPMxjkx7A0oFZGIoZaoiXz/ppRGxl7VOaEX1qCzAZDD497YhSkgkNC6JiJSJ4K4EzDarRFtW5l4RGXPRXwGRrkKC13UvDLUynxmhLsGAA/jrzB5SxZ5MfRpbC+Qj3eJ8lf2M+cRSJD+y0xr4oEM5AHZeIv/h/xgS0i5XLLfE1lw4b6f0R81Y0tXCUpNR4zSqh8lEET0lzf3jwZNffaZMCQb0QHad5X/ytg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; 
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C2d5SbB0gGCeI/m53gKNq2Ey8IpAubWrtI+2S3wn08M=;
 b=rn2etc0yLvFVuw5fLqjSjlkIhYtf27wAICaijUchIcC9YJkX+iyvdfH/Ag1WNOjC7Y/Zq5E/FTkrs10o7dGJLAUua4GF3QjUoal/yUaNP2ZkQcWEHkF2PbWLOgSCui/dyyB5lYtN/67h76SllmudhWBsD4wZ4BpOvdCXKQPH+0M=
Received: from DBBPR08MB5915.eurprd08.prod.outlook.com (2603:10a6:10:20d::17)
 by DB7PR08MB3787.eurprd08.prod.outlook.com (2603:10a6:10:33::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec
 2021 11:49:11 +0000
Received: from DBBPR08MB5915.eurprd08.prod.outlook.com
 ([fe80::dd96:eb7:b263:b290]) by DBBPR08MB5915.eurprd08.prod.outlook.com
 ([fe80::dd96:eb7:b263:b290%4]) with mapi id 15.20.4755.022; Tue, 7 Dec 2021
 11:49:10 +0000
From: Hannes Tschofenig <Hannes.Tschofenig@arm.com>
To: "rats@ietf.org" <rats@ietf.org>
Thread-Topic: EAT Review Comments
Thread-Index: AdfrXtD82TqKBMPPTvW26/ecfE3BXw==
Date: Tue, 7 Dec 2021 11:49:10 +0000
Message-ID: <DBBPR08MB59150EEE386E675005A52124FA6E9@DBBPR08MB5915.eurprd08.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ts-tracking-id: C21A78C1926F2E49BAEE8E2C811FA941.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: bafa828b-b2cb-457d-a995-08d9b9779aa8
x-ms-traffictypediagnostic: DB7PR08MB3787:EE_|VE1EUR03FT052:EE_|DBAPR08MB5735:EE_
X-Microsoft-Antispam-PRVS: <DBAPR08MB573516520B6B200080619B27FA6E9@DBAPR08MB5735.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: R3sHG6ZPLIY1rGrIvwVl/K3Pxb4302hMDdPhRFaqHDzMYRWUwBafGT9vP2QyHpfHeFGGivIM3XGenpplISCitV31/hh3+N9Z6K+oz76MCITUYCvxLMCY1a1Y2TuTSIHOPzVa+S8e+G0cxmE/uBFB/TLeJCOXiWBsM5u/3umjqB8AoKhh0wx6qut3VtiO3sSbu0WjIlfWGPK05NBlAEF/teu1S7QyRFjpQB6WLYTv2iuHHi3V5x3fHg4WslCCsS/belaAV+JfegNy+/yYIe9ytzW5NJ+MgLAktTpK2dyFAuA636stYMwgTJUWTXUPWsJGNoklZ6kRA2y4KJFKqq2UYcSXkT2ko3BdZ0ky5QpN0Yswc0YU+R9jWJOZjsdJY35nzi5g74Dxa8toR1TOt7X+fjxC5xa8Oy8Imx/OR50dD0/Eix1sOi+T/t5eJRUp0HQNNuTcY3eKGE4XHFXVTU7Qz/FFbm9PPk9RCT0iac2vD6maffmGd+175NkFJWc5St3Tmu9Tex0/Ae/92UDB4eIq1pVP/MEkd1jaMr+fuMa9I4aikwAZA2i6lc4HpWNKzcjS6utc62XKGCswLdvOrm0NUMFPp09YgySfR0PS/Yy/zlo6EEpcVRLdrlvY3MULwIIg4OxPr81VIWrWPPf+thLjL5tcB4VydOswqYYiJ2QTAqWmo6LZ6ic+VAVu3lJvcRpZnh1iDHZD7AGWWVUeKSVFtg==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en;
 SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB5915.eurprd08.prod.outlook.com;
 PTR:; CAT:NONE;
 SFS:(4636009)(366004)(33656002)(5660300002)(52536014)(316002)(186003)(8676002)(6506007)(508600001)(7696005)(55016003)(7116003)(86362001)(83380400001)(26005)(9686003)(6916009)(66556008)(2906002)(122000001)(8936002)(66446008)(66946007)(66476007)(76116006)(64756008)(38100700002)(3480700007)(71200400001)(38070700005);
 DIR:OUT; SFP:1101; 
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3787
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 5f12dae1-e493-492c-60dd-08d9b977956d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xwDa69z8xHIwpYYOotdVPXfH6pAIQx1c5ZyUxOQYii6OuwwHJIbyqNGgh1ux/D4cnEQCEWB99S9DWOArZLuUHKnCTqNjsGJvQJBKKN7qpvjulXb3ItvhwKReRnBw2Wlh2BsWIqFzjCA12lZeBaunkcmQdozhlJ9ov6++E5/xnb+RJzAzL6viBw7B0A88h46WGFHplFDv5G6RPKvH5wGhDzmhpny7CikMiKRXUh5ffQjGu8C+2UIKwI89rJRvn4kFq4+Uq44EpLfvx5pWSFGF+H+IQ5eaCcYcdNj3oa1nrmXU7malKxDp+rjh5tpO3kKxl7Uopo8f5TYZ1cdtPMgvWZGdIBquYqV5l8TmAFfWbq78EuMsq2/u9EkyB1gQ2oBFJqfdYNPeVOi6Z8XsdpGdkVX3LOA2Ch8kZ0n3O5LohClsjjlq1YWcqJKhY6uZwNFAT7ut16VHuTa0xwK68lfkeUW68TMgTyUgOvcNwIR0l9v+daw2Z+ZCAPUl0rk/72QDBQypGHQx6ZxiONK/qgh+KvcpCAWg8SraiyWcrjwKkl4iGKxo1TPfkaGygxnKnC6fGk7ajzrV4f2j1MzVXCanw0XddNlWg6ACQqivO2rIiptcIplbywTXK/auZ9EQ85gqIQLY/3crDVgC5h3rrohS9X3BMm2swSTS97+7fpcNGDscL9rJmKHEILf2fO9/ySVjOABxDnwz0XWfzupcYs0urg==
X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; 
 IPV:CAL; SFV:NSPM;
 H:64aa7808-outbound-1.mta.getcheckrecipient.com; 
 PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE;
 SFS:(4636009)(36840700001)(46966006)(52536014)(70206006)(81166007)(2906002)(8936002)(26005)(33656002)(70586007)(186003)(9686003)(8676002)(356005)(86362001)(7116003)(36860700001)(6916009)(316002)(83380400001)(508600001)(47076005)(5660300002)(55016003)(3480700007)(7696005)(82310400004)(336012)(6506007);
 DIR:OUT; SFP:1101; 
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 11:49:19.5533 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bafa828b-b2cb-457d-a995-08d9b9779aa8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; 
 Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5735
Archived-At: <https://mailarchive.ietf.org/arch/msg/rats/hEXYdxxGP63QD_w-S_a4uDe0OEg>
Subject: [Rats] EAT Review Comments
X-BeenThere: rats@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Remote ATtestation procedureS <rats.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rats>,
 <mailto:rats-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rats/>
List-Post: <mailto:rats@ietf.org>
List-Help: <mailto:rats-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rats>,
 <mailto:rats-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Dec 2021 11:49:27 -0000

Hi all,

As promised, here are some high-level review comments, which are most impor=
tant to us:

- The document would benefit from a normative language. Think in the follow=
ing way: What does a party creating a claim and a party verifying the claim=
 have to do in order to ensure interoperability. Use SHOULDs and MAYs when =
you can give the reader a decision path.

- Don't put comments into the CDDL since the same text is already in the dr=
aft. You are essentially putting the text in the document twice. This will =
reduce the size of the document.

- Normative vs. informative references: If you need to read a specification=
 as a developer in order to implement a listed claim then this reference is=
 normative. For example, the location claim cannot be implemented without h=
aving to open the W3C geolocation API. Hence, that reference becomes normat=
ive.

- Aim for consistent use of terminology. An example is the use of "entity",=
 "entity/device", "device/entity", "entity/client device", "device entity",=
 "entity or submod", "entity (typically a device)". In Section 1.4 you seem=
 to suggest that "entity" is the right term. But throughout the text you mi=
x the terms. The  EAT draft should adopt the terminology established in the=
 architecture doc, which would be "attester" rather than "entity". Section =
2 should import the vocabulary from the architecture document **by referenc=
e** and establish the aliasing "attester" =3D "entity" (and maybe =3D "devi=
ce") by saying something along these lines: "attester and entity are used i=
nterchangeably in this document".

- The spec is long and there is a lot of feature creep. This makes it appea=
r very complex. I believe there are two reasons for this, namely (a) there =
is suddenly a lot of architectural discussion in this document. This is unn=
ecessary given that there is a separate architecture document. There is no =
need to repeat the content here as well. Do you expect a reader to go throu=
gh the architecture document before reading this document? (b) There are cl=
aims in this specification that may sound good but I wonder whether they ar=
e ready for prime time already. This document does not need to collect all =
claims that relate to attestation. Most likely there is not much experience=
 implementing some of these claims either, which reduces the quality of the=
 specification. Sometimes less is just more.

- Unprotected CWT Claims Sets (UCCS): I see UCCS as an architectural aspect=
. Normally, the implications for the EAT spec should be quite small. The pu=
rpose of the EAT spec is to define claims that go into a CWT. EAT does not =
mandate a specific way to protect the claims (digital signature, MAC, encry=
ption, etc.) then UCCS has not much implication besides a short mention in =
the security consideration section. Given that UCCS is a separate working g=
roup document we would remove Section 4 along with any reference to UJCS.

Ciao
Hannes & Thomas




IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.

