[Rats] Some Feedback on CHARRA

[William Bellingrath <[e-mail]>]

 Hi all,

We have been discussing the CHARRA yang module, and I would like to float back some feedback and recommendations from my colleagues.
Comments are predominantly aimed at naming conventions, or ease of reading, and are just suggestions.


1.
module ietf-tpm-remote-attestation {
  namespace "urn:ietf:params:xml:ns:yang:ietf-tpm-remote-attestation";
  prefix "tpm";

  import ietf-yang-types {
    prefix yang;
  }
  import ietf-hardware {
    prefix ietfhw;
  }
  import ietf-keystore {
    prefix ks;
  }
  import ietf-tcg-algs {
    prefix taa;
  }
Recommend these prefix names changed to something easier to read.


2.
...
must "/tpm:rats-support-structures/tpm:attester-supported-algos"
         + "/tpm:tpm20-asymmetric-signing";
 ...

Recommend adding an error message or description with the “must” statements.


3. For all identity naming, recommend using '-' instead of '_'.
E.x. grouping TPM2_Algo, grouping TPM12_Algo, etc


4.
      leaf revMajor {
…
      leaf revMinor {
…
Recommend renaming these to ‘rev-major’ and ‘rev-minor’


Thanks,
William Bellingrath


Juniper Business Use Only